Repository navigation
refactor(sink): add a generic Sink wrapper around the Kafka sink - #4
Merged
Merged
Conversation
gagantrivedi
changed the title
The handler passes typed EventRecords to the sink, which encodes them. New SINK env var (default kafka); Kafka settings are only read when SINK=kafka. No behaviour change. Refs #3
gagantrivedi
force-pushed
the
generic-sink
branch
from
October 27, 2026 05:36
47784f1 to
3779a7f
Compare
4 tasks done
Zaimwa9
previously approved these changes
Oct 27, 2026
Move SinkError to the sink module, with a Kafka variant ready for other sinks. No behaviour change. Refs #3
EventRecord borrows traits and metadata as JSON values; serializing the record encodes them as JSON strings, so the handler does no encoding and Kafka output is unchanged. Deciding the sink kind no longer reads the environment, so an unset SINK defaulting to kafka is tested. Refs #3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First step towards writing events directly to ClickHouse and Postgres. Refs #3
EventRecords to the sink, which encodes them; Kafka wire bytes are unchanged.Sinkenum (Kafka only for now) used by routes,/healthandmain.SINKenv var (defaultkafka); Kafka settings are only read whenSINK=kafka.No behaviour change.