Repository navigation
ci: Measure only SDK calls in CodSpeed using instrument-hooks - #119
Merged
Merged
Conversation
Run all benchmarks in one process, measuring each SDK call through a native extension built on CodSpeed's instrument-hooks. Ruby start-up, loading the SDK and building the client no longer count towards the results.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
GCC 15, which ships with Ubuntu 26.04 runners, defaults to C23, where zig.h's noreturn expands to an attribute that the generated core.c places after the storage class, failing the build. Pin C11 like pytest-codspeed does.
Merging this PR will not alter performance
Performance Changes
Comparing Footnotes
|
emyller
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, we make sure that interpreter startup does not skew benchmark results, and affect the benchmark runtimes.
To achieve this, we basically whip up a quick
pytest-codspeedport for Ruby, wrapping CodSpeed's instrument-hooks.