You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Adds Ruby 3.4 and 4.0, the two most recent supported releases, to the CI matrix.
Ruby 4.0 needed a few dependency changes:
Bump the locked faraday-retry from 2.2.1 to 2.4.0: earlier versions declare required_ruby_version < 4, so bundle install failed. 2.4.0 still supports Ruby >= 2.6.
Add benchmark as a development dependency: RuboCop 1.60 requires it, and it's no longer a default gem in Ruby 4.0.
Add ostruct as a development dependency: the specs use OpenStruct, which is no longer a default gem in Ruby 4.0.
No runtime dependencies change other than the faraday-retry lock bump.
No actionable comments were generated in the recent review.
Recent review info
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: ASSERTIVE
Plan: Advanced
Run ID: b896bd7d-f94f-407d-ad85-35e01ea79bd1
Commits
Reviewing files that changed from the base of the PR and between f10b360 and 6001d74.
Files ignored due to path filters: 1
Gemfile.lock is excluded by !**/*.lock
Files selected for processing: 2
.github/workflows/pull_request.yaml
flagsmith.gemspec
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
Walkthrough
The pull request workflow adds Ruby 3.4 and 4.0 to the test matrix. The gemspec adds benchmark and ostruct as development dependencies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Ruby 3.4 and 4.0, the two most recent supported releases, to the CI matrix.
Ruby 4.0 needed a few dependency changes:
faraday-retryfrom 2.2.1 to 2.4.0: earlier versions declarerequired_ruby_version < 4, sobundle installfailed. 2.4.0 still supports Ruby >= 2.6.benchmarkas a development dependency: RuboCop 1.60 requires it, and it's no longer a default gem in Ruby 4.0.ostructas a development dependency: the specs useOpenStruct, which is no longer a default gem in Ruby 4.0.No runtime dependencies change other than the
faraday-retrylock bump.