Repository navigation
feat(Engine): Report the STATIC reason for flags without targeting - #242
Merged
emyller merged 2 commits intoNov 2, 2026
Conversation
A flag evaluated to its environment default now reports `STATIC` when no segment overrides its feature, and `DEFAULT` when segments override it but none matched, as flagsmith-engine#347 and the Rust engine do. engine-test-data moves to v3.12.1, which expects the new reason. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
 |
…nvironment Collecting every segment override name, identity overrides included, on each evaluation made identity flags 13–17% slower. The environment mapper now collects them once into `EngineEvaluationContext.TargetedFeatureNames`, and the engine only computes them for contexts that lack them. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
emyller
merged commit Nov 2, 2026
cf4ab38
into
linear/sdk-3-enable-flag-dependency-in-the-go-server-side-sdk-3091
7 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Local evaluation reports
DEFAULTfor every flag served its environment default, unlike flagsmith-engine since #347 and the Rust engine.Stacked on #238. Contributes to SDK-3. Tested by engine-test-data v3.12.1; supersedes #227.
Changes
STATICwhen no segment overrides the feature, andDEFAULTwhen segments override it but none matched.Flags without targeting change reason from
DEFAULTtoSTATIC, including environment flags.🤖 Generated with Claude Code