fix-improving-tracking-of-aborted-streams#160
Merged
Conversation
noahpodgurski
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a user closes the app or cancels a stream mid-response, Starlette throws GeneratorExit (or cancels the task) into the streaming generator. We weren't catching that, so the result stayed at its initial error
value and got recorded as an error in the latency metric.
It's important because our disconnect detection relies on a poller that checks every 100ms. The teardown almost always happens before the poller fires, so most disconnects were slipping through and landing in the
error bucket.
I believe that this could be dragging down the s2s success rate.