storage(schema): enforce enrollment event reference shape - #62
Merged
Conversation
TusanHomichi
marked this pull request as ready for review
September 5, 2026 00:48
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migration 0006 permits a withdrawal, completion, or reinstatement with exactly one program-version reference. Migration 0014 makes the full shape a database-enforced rule: version changes name both versions, and other kinds name neither.
BEFORE INSERTshape trigger, retaining the existing unconditional no-update trigger, CHECK constraints, indexes, and incoming phase-event references.enrollment_event_legacy_version_references_invalidconstraint; startup stops, and the migration transaction leaves history, schema, and ledger unchanged. No guessed correction or deletion occurs.Validated locally at
b9c50da0f735ad447fe3a175005bf5000861db90:npm ci,npm run check,npm run build,cargo fmt --check,cargo clippy --workspace --all-targets -- -D warnings,cargo test --workspace(134 passed),cargo build -p consolebook-server,npx playwright install chromium, andnpm run e2e -- --workers=2 --trace retain-on-failure(8 passed). Heavy suites ran sequentially; browser concurrency was limited to two workers on the shared development machine. The web install still reports the three existing low-severity npm audit entries tracked in #54.No packet-format, service API, historical migration checksum, or preview deployment changes. Valid upgrades scan the event history without rewriting its table; malformed legacy history requires a separately authorized repair decision.
Closes #51.