records(packet): verify the pin timeline for recorded acts - #61
Merged
Conversation
TusanHomichi
marked this pull request as ready for review
September 5, 2026 00:13
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A canonical, rehashed trainee packet could attribute a signoff to a program version pinned only later, or place phase activity outside its named pin epoch. Verification now checks when the claimed version was pinned and reports
DocumentPinHistoryfor temporal contradictions.signed_at; phase effective/recorded instants must obey their explicit epoch boundaries. Reject version-change timestamps that reverse recorded order.tests/trainee_packet/pin_history.rs, with shared fixtures/helpers retained by the parent. No public or persisted impact from the test reorganization. Add canonical, rehashed forgeries, exact boundary cases, revisited versions, and a round trip through domain services and the real exporter.Validation at
051a10e:npm ci,npm run check,npm run build;cargo fmt --check;cargo clippy --workspace --all-targets -- -D warnings; all 130 workspace Rust tests; explicit debug binary build; and all eight browser tests (npm run e2e -- --workers=2 --trace retain-on-failure, 30.0 seconds) pass. Heavy local suites ran sequentially. The web install reports the three existing low-severity npm audit entries tracked in #54.The verifier checks consistency with the supplied history and fingerprints. It cannot establish provenance or resolve unstored subsecond ordering; a backwards clock that produces contradictory change timestamps is reported rather than silently reordered. No preview deployment is included.
Closes #52.