Skip to content

records(packet): verify the pin timeline for recorded acts - #61

Merged
TusanHomichi merged 2 commits into
mainfrom
codex/52-packet-pin-timeline
Sep 5, 2026
Merged

records(packet): verify the pin timeline for recorded acts#61
TusanHomichi merged 2 commits into
mainfrom
codex/52-packet-pin-timeline

Conversation

@TusanHomichi

@TusanHomichi TusanHomichi commented Sep 5, 2026

Copy link
Copy Markdown
Member

A canonical, rehashed trainee packet could attribute a signoff to a program version pinned only later, or place phase activity outside its named pin epoch. Verification now checks when the claimed version was pinned and reports DocumentPinHistory for temporal contradictions.

  • Retain each epoch's opening and closing instants. Signoffs must name a version pinned at signed_at; phase effective/recorded instants must obey their explicit epoch boundaries. Reject version-change timestamps that reverse recorded order.
  • Keep boundary seconds inclusive: changes and acts within one Unix second cannot be ordered across tables. Preserve intermediate pins during multiple same-second changes and distinguish separate visits to an earlier version.
  • Add ADR 0017 and update normative check 8. The producer already carries the required fields, so packet format version 1 and stored bytes remain unchanged.
  • Move pin-history tests into tests/trainee_packet/pin_history.rs, with shared fixtures/helpers retained by the parent. No public or persisted impact from the test reorganization. Add canonical, rehashed forgeries, exact boundary cases, revisited versions, and a round trip through domain services and the real exporter.

Validation at 051a10e: npm ci, npm run check, npm run build; cargo fmt --check; cargo clippy --workspace --all-targets -- -D warnings; all 130 workspace Rust tests; explicit debug binary build; and all eight browser tests (npm run e2e -- --workers=2 --trace retain-on-failure, 30.0 seconds) pass. Heavy local suites ran sequentially. The web install reports the three existing low-severity npm audit entries tracked in #54.

The verifier checks consistency with the supplied history and fingerprints. It cannot establish provenance or resolve unstored subsecond ordering; a backwards clock that produces contradictory change timestamps is reported rather than silently reordered. No preview deployment is included.

Closes #52.

@TusanHomichi
TusanHomichi marked this pull request as ready for review September 5, 2026 00:13
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 5, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-05T00:17:00.243091Z 051a10e Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@TusanHomichi
TusanHomichi merged commit 14f76f2 into main Sep 5, 2026
1 check passed
@TusanHomichi
TusanHomichi deleted the codex/52-packet-pin-timeline branch September 5, 2026 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

records(packet): bind signoffs and phase events to the pin timeline in verification

1 participant