storage(doctor): preserve journal mode during diagnosis - #60
Merged
Conversation
TusanHomichi
marked this pull request as ready for review
September 4, 2026 23:50
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
doctorpreviously set WAL through the writable backup options before checking journal mode. A DELETE-mode installation now stays byte-identical and reportsexpected wal, got delete.Validation at
94fd4f3: web install/check/build, Rust fmt/Clippy, all 125 Rust tests, explicit debug binary build, all eight browser tests (npm run e2e -- --trace on), and the original #56 CLI reproduction pass.npm audit --jsonstill exits 1 for the three low-severity entries already tracked in #54.The first browser run overlapped the Rust suite and finished 7/8: the draft workflow exhausted its overall 60-second timeout at
drafts.spec.ts:394during login. After inspecting the timeout and pending-login snapshot, the browser suite ran separately in the documented sequence with tracing: all eight passed in 41.9 seconds, including the draft workflow in 38.9 seconds. Other workflows also improved from 13–22 seconds to 11–12 seconds, supporting resource contention as the cause. No test timeout or application behavior changed.The filesystem tests use Unix permissions with an unprivileged runner; they are not a mounted read-only filesystem or crash-recovery drill. The preview has not been deployed.
Closes #56.