Repository navigation
Add cross-platform application menu and release 0.3.0 - #4
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GPUI 0.2.2 stores application menus on Windows and Linux without rendering a native menu bar, leaving app settings and tools inaccessible. Add a Menu button only on Windows and Linux, in the top toolbar and empty start screen that renders the current
cx.get_menus()entries and dispatches their actions throughwindow.dispatch_action.macOS continues to use its native menu bar without the new button. The popup preserves nested settings groups and theme checkmarks, excludes macOS system menus, Hide/Show actions and Window, scrolls within the viewport, and dismisses on outside clicks or Escape. Escape also dismisses About and timeline context menus. Prepare version 0.3.0 in workspace metadata, Cargo.lock, Linux metainfo, release notes and download links.
Validation:
cargo fmt --all -- --checkcargo clippy --workspace --all-targets -- -D warningscargo test --workspace: 370 passed, one existing ignored testRUSTDOCFLAGS="-D warnings" cargo doc --workspace --no-depsWindows and Linux compilation and tests run in the PR's existing CI matrix. Publishing tag
v0.3.0after merge uses the existing release workflow for all installers and source archives.