Fix swapped shared-buffer constants in Smile async parser - #771
Open
pjfanning wants to merge 1 commit into
Open
Conversation
`NonBlockingParserBase._expandSeenNames()` compared the current length against `DEFAULT_STRING_VALUE_BUFFER_LENGTH`, and `_expandSeenStringValues()` against `DEFAULT_NAME_BUFFER_LENGTH` -- each using the other one's constant. Both constants are currently 64, so the growth steps come out the same and there is no behavioural change today. But the pairing is wrong, and retuning either constant independently would silently break the growth sequence of the other table. This mirrors the same fix already applied to the blocking `SmileParser`. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
🧪 Code Coverage Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
NonBlockingParserBase, the two shared-table growth methods use each other's constant:_expandSeenNames()compares the current length againstDEFAULT_STRING_VALUE_BUFFER_LENGTH_expandSeenStringValues()compares againstDEFAULT_NAME_BUFFER_LENGTHBoth constants are
64today, so the growth sequence comes out the same either way and there is no behavioural change — this is a latent bug only. But the pairing is wrong, and retuning either constant on its own would silently break the growth steps of the other table.Same fix as was already applied to the blocking
SmileParser- #746Smile module tests pass.
🤖 Generated with Claude Code