Allow for @JacksonXmlText in deserialization with nested builders - #906
Open
yuzawa-san wants to merge 1 commit into
Open
Allow for @JacksonXmlText in deserialization with nested builders#906yuzawa-san wants to merge 1 commit into
@JacksonXmlText in deserialization with nested builders#906yuzawa-san wants to merge 1 commit into
Conversation
BuilderWithTextValueTest.testNestedBuilderWithTextValue:101 » Databind Cannot cast tools.jackson.dataformat.xml.deser.builder.BuilderWithTextValueTest$Inner$InnerBuilder to tools.jackson.dataformat.xml.deser.builder.BuilderWithTextValueTest$Inner at [Source: (String)"<Outer><Inner>Value</Inner></Outer>"; line: 1, column: 28] (through reference chain: tools.jackson.dataformat.xml.deser.builder.BuilderWithTextValueTest$Outer$OuterBuilder["Inner"])
yuzawa-san
changed the title
@JacksonXmlText in nested builders@JacksonXmlText in deserialization with nested builders
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wrote a breaking test with my schema (that has builders) and it failed with:
It appears the XmlTextDeserializer tries to return a builder to a calling deserializer which is expecting a real instance.
I believe the solution is to make the logic to use createUsingDefault to consider if there is the ValueInstantiator returns a builder.
If there is a builder then use the logic in _deserializeFromStringViaDelegate