guard ToXmlGenerator cast in serializeWithType()/_serializeObjectId() for convertValue() - #905
Open
Sahana2524 wants to merge 1 commit into
Open
guard ToXmlGenerator cast in serializeWithType()/_serializeObjectId() for convertValue()#905Sahana2524 wants to merge 1 commit into
Sahana2524 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ClassCastExceptionfromXmlMapper.valueToTree()/convertValue()on any@JsonTypeInfo(include = As.PROPERTY)bean (the default inclusion):serializeWithType()and_serializeObjectId()cast the generator toToXmlGeneratorto flag the type id as an attribute, but those two conversion entry points serialize into aTokenBuffer/ tree generator rather than aToXmlGenerator. The sibling methods_serializeProperties()and_serializePropertiesFiltered()in the same class already skip the XML-specific handling with aninstanceof ToXmlGeneratorguard (comment: "During 'convertValue()', need to skip"); these two type-id paths were the only ones missing it, so I added the same guard to both.Real XML serialization is unchanged: the type id is still written as an attribute. Added a small regression test covering
valueToTree,convertValue, and the unchanged XML output.