Skip to content

New JsonPointer method: public boolean startsWith(JsonPointer other) - #1636

Merged
cowtowncoder merged 5 commits into
FasterXML:3.xfrom
scottslewis:jsonpointer_startsWith
Jul 25, 2026
Merged

New JsonPointer method: public boolean startsWith(JsonPointer other) #1636
cowtowncoder merged 5 commits into
FasterXML:3.xfrom
scottslewis:jsonpointer_startsWith

Conversation

@scottslewis

@scottslewis scottslewis commented Jul 20, 2026 •
edited by cowtowncoder
Loading

Copy link
Copy Markdown
Contributor

See FasterXML/jackson-databind#6045 (comment) for context for this addition.
Fixes #1637.

Also added JsonPointerStartsWithTest to test startsWith method.

@scottslewis
Added JsonPointer public boolean startsWith(JsonPointer other method.
e46dc57 
Also added JsonPointerStartsWithTest that tests the new method.
@scottslewis scottslewis changed the title Added JsonPointer method: public boolean startsWith(JsonPointer other method. New JsonPointer method: public boolean startsWith(JsonPointer other) Jul 20, 2026
This was referenced Jul 20, 2026
Closed
Open
@cowtowncoder cowtowncoder added the cla-needed PR looks good (although may also require code review), but CLA needed from submitter label Jul 24, 2026
@cowtowncoder

cowtowncoder commented Jul 24, 2026

Copy link
Copy Markdown
Member

Will review more tomorrow, but looks good.

The only process thing: have I asked for CLA before? If so, never mind, but if not, would need it from:

https://github.com/FasterXML/jackson/blob/main/CLA-jackson-2026.pdf

and as usual, covers all PRs. Filled & signed, email to cla at fasterxml dot com.

Looking forward to merging this!

@scottslewis

scottslewis commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

Will review more tomorrow, but looks good.

The only process thing: have I asked for CLA before? If so, never mind, but if not, would need it from:

https://github.com/FasterXML/jackson/blob/main/CLA-jackson-2026.pdf

and as usual, covers all PRs. Filled & signed, email to cla at fasterxml dot com.

Looking forward to merging this!

I'm going to be away next week (Aug 27), so will try to get you the cla before going. For my information, other than yourself, who is considered 'maintainers of the Jackson project'?

FWIW, I did generate this code and tests via an AI service: codeconvert.ai. According to their terms, I retain all rights wrt the generated code.

@scottslewis

scottslewis commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

and as usual, covers all PRs. Filled & signed, email to cla at fasterxml dot com.

Done.

@cowtowncoder

cowtowncoder commented Jul 24, 2026

Copy link
Copy Markdown
Member

For my information, other than yourself, who is considered 'maintainers of the Jackson project'?

It'd be devs with push access to one or more of Jackson repos, half a dozen devs such as @pjfanning and @JooHyukKim.

@cowtowncoder

cowtowncoder commented Jul 25, 2026

Copy link
Copy Markdown
Member

and as usual, covers all PRs. Filled & signed, email to cla at fasterxml dot com.

Done.

First didn't see it, but then found out GMail had put in spam, all good now. :)

@cowtowncoder cowtowncoder added cla-received PR already covered by CLA (optional label) and removed cla-needed PR looks good (although may also require code review), but CLA needed from submitter labels Jul 25, 2026
@cowtowncoder
cowtowncoder merged commit a983197 into FasterXML:3.x Jul 25, 2026
4 checks passed
@cowtowncoder cowtowncoder added this to the 3.3.0 milestone Jul 25, 2026
@cowtowncoder

cowtowncoder commented Jul 25, 2026

Copy link
Copy Markdown
Member

Merged; thank you @scottslewis !

@github-actions

github-actions Bot commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

📈 Overall Code Coverage

Metric Coverage Change
Instructions coverage 83.16% 📉 -0.010%
Branches branches 76.01% 📈 +0.070%

Overall project coverage from JaCoCo test results. Change values compare against the latest base branch build.

scottslewis added a commit to scottslewis/jackson-databind that referenced this pull request Jul 25, 2026
@scottslewis
This commit fixes the toString()-based JsonPointer comparison issue
ebd12d3 
frm line 206-207 of JRefModule discussed starting with this comment:

FasterXML#6045 (comment)

The fix is to use the newly merged JsonPointer.startsWith(JsonPointer
other) method added in jackson-core via pr this pr:
FasterXML/jackson-core#1636

This means that the latest of Jackson-core 3.x branch will be required
to compile the updated JRefModule.
pjfanning pushed a commit to pjfanning/jackson-core that referenced this pull request Aug 14, 2026
@scottslewis @pjfanning
New JsonPointer method: public boolean startsWith(JsonPointer other) (F…
9b368b2 
…asterXML#1636)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cowtowncoder cowtowncoder cowtowncoder approved these changes

Assignees

No one assigned

Labels

cla-received PR already covered by CLA (optional label)

Projects

None yet

Milestone

3.3.0

Development

Successfully merging this pull request may close these issues.

Add JsonPointer.startsWith() method

2 participants

@scottslewis @cowtowncoder