-
Notifications
You must be signed in to change notification settings - Fork 134
feat(loaders): add Microsoft SQL Server support #734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Anchel123
wants to merge
11
commits into
staging
Choose a base branch
from
feat/sqlserver-support-rebased
base: staging
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
d787625
feat(loaders): add Microsoft SQL Server support
gkorland 32ce161
fix(loaders): validate SQL Server identifiers before interpolation
gkorland 889d97c
fix(loaders): qualify SQL Server sample queries with the catalog schema
gkorland ac1143e
fix(loaders): drop URL-schema fallback in SQL Server sample queries
gkorland 563fd2c
fix(loaders): offload SQL Server introspection off the event loop
Anchel123 567c795
fix(loaders): bound SQL Server connect and query time
Anchel123 a0a0cb9
fix(loaders): use one process-wide pymssql timeout
Anchel123 050db37
test(loaders): cover SQL Server refresh, routing and URL edge cases
Anchel123 87a1558
fix(sql): stop a broken-out delimiter passing as a quoted identifier
Anchel123 3607803
Merge remote-tracking branch 'origin/staging' into feat/sqlserver-sup…
Anchel123 926f91a
fix(sqlserver): refuse a dotted name the sampler cannot disambiguate
Anchel123 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -124,3 +124,11 @@ SDK | |
| Dependabot | ||
| PyPI | ||
| pypi | ||
| pymssql | ||
| sqlserver | ||
| SQLServerLoader | ||
| dbo | ||
| tsql | ||
| hostname | ||
| TLS | ||
| sqlglot | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.