Honor git.noVerify from RepoConventions#70
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the gitattributes-lf convention to honor RepoConventions’ --git-no-verify request so that convention-generated commits can bypass local Git hooks (e.g., commitlint/husky), aligning convention behavior with the caller’s intent.
Changes:
- Added
Read-ConventionGitNoVerifyhelper to readgit.noVerifyfrom the RepoConventions input JSON. - Updated
gitattributes-lfto append--no-verifytogit commitwhen requested. - Added Pester coverage validating behavior with and without the hook bypass request.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| conventions/scripts/TestHelpers.ps1 | Extends test input generation to include git.noVerify for structured inputs. |
| conventions/scripts/Helpers.ps1 | Adds Read-ConventionGitNoVerify to read the git.noVerify flag from input JSON. |
| conventions/gitattributes-lf/convention.Tests.ps1 | Adds tests covering commit hook bypass and non-bypass scenarios. |
| conventions/gitattributes-lf/convention.ps1 | Uses git.noVerify to conditionally pass --no-verify to commit creation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ejball
approved these changes
Jun 9, 2026
Prettier is checking these paths [in reading-plan-wizard][1]. [1]: https://github.com/LogosBible/reading-plan-wizard/actions/runs/27241178545/job/80445018278?pr=288#step:10:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on Faithlife/RepoConventions#54.
I was trying to add Repo Conventions to reading-plan-wizard, and I used
--git-no-verifyin an attempt to bypass the Commitlint hook there. The commits executed by RepoConventions itself succeeded, but the firstgitattributes-lfcommit failed:With this change (on top of Faithlife/RepoConventions#54), the
gitattributes-lfcommits succeed in my local reading-plan-wizard. 🥳