Harden Ledger interactive submission end to end

.github/workflows/test-cn-quickstart.yml

@@ -90,7 +90,13 @@ jobs:
 
       - name: Start CN-Quickstart
         run: |
-          npm run localnet:start
+          splice_version="$(tr -d '[:space:]' < libs/splice/VERSION)"
+          if [[ ! "${splice_version}" =~ ^[0-9]+\.[0-9]+\.[0-9]+$ ]]; then
+            echo "Invalid pinned Splice version: ${splice_version}" >&2
+            exit 1
+          fi
+          echo "Starting CN-Quickstart with pinned Splice ${splice_version}"
+          CANTON_LOCALNET_SPLICE_VERSION="${splice_version}" npm run localnet:start
           echo "✓ CN-Quickstart started"
         timeout-minutes: 15
 

src/clients/ledger-json-api/operations/v2/interactive-submission/execute-and-wait-for-transaction.ts

@@ -0,0 +1,22 @@
+import { createApiOperation } from '../../../../../core';
+import {
+  InteractiveSubmissionExecuteAndWaitForTransactionRequestSchema,
+  InteractiveSubmissionExecuteAndWaitForTransactionResponseSchema,
+  type InteractiveSubmissionExecuteAndWaitForTransactionRequest,
+  type InteractiveSubmissionExecuteAndWaitForTransactionResponse,
+} from '../../../schemas/api/interactive-submission';
+/** Execute an interactive submission and wait for the resulting transaction. */
+export const InteractiveSubmissionExecuteAndWaitForTransaction = createApiOperation<
+  InteractiveSubmissionExecuteAndWaitForTransactionRequest,
+  InteractiveSubmissionExecuteAndWaitForTransactionResponse
+>({
+  paramsSchema: InteractiveSubmissionExecuteAndWaitForTransactionRequestSchema,
+  responseSchema: InteractiveSubmissionExecuteAndWaitForTransactionResponseSchema,
+  method: 'POST',
+  buildUrl: (_params, apiUrl) => `${apiUrl}/v2/interactive-submission/executeAndWaitForTransaction`,
+  buildRequestData: (params) => ({
+    ...params,
+    deduplicationPeriod: params.deduplicationPeriod ?? { Empty: {} },
+  }),
+  getFreshRetryIdentifier: (params) => params.submissionId,
+});

src/clients/ledger-json-api/operations/v2/interactive-submission/execute-and-wait.ts

@@ -0,0 +1,22 @@
+import { createApiOperation } from '../../../../../core';
+import {
+  InteractiveSubmissionExecuteAndWaitRequestSchema,
+  InteractiveSubmissionExecuteAndWaitResponseSchema,
+  type InteractiveSubmissionExecuteAndWaitRequest,
+  type InteractiveSubmissionExecuteAndWaitResponse,
+} from '../../../schemas/api/interactive-submission';
+/** Execute an interactive submission and wait for its completion. */
+export const InteractiveSubmissionExecuteAndWait = createApiOperation<
+  InteractiveSubmissionExecuteAndWaitRequest,
+  InteractiveSubmissionExecuteAndWaitResponse
+>({
+  paramsSchema: InteractiveSubmissionExecuteAndWaitRequestSchema,
+  responseSchema: InteractiveSubmissionExecuteAndWaitResponseSchema,
+  method: 'POST',
+  buildUrl: (_params, apiUrl) => `${apiUrl}/v2/interactive-submission/executeAndWait`,
+  buildRequestData: (params) => ({
+    ...params,
+    deduplicationPeriod: params.deduplicationPeriod ?? { Empty: {} },
+  }),
+  getFreshRetryIdentifier: (params) => params.submissionId,
+});

src/clients/ledger-json-api/operations/v2/interactive-submission/execute.ts

@@ -1,18 +1,23 @@
 import { createApiOperation } from '../../../../../core';
 import {
   InteractiveSubmissionExecuteRequestSchema,
+  InteractiveSubmissionExecuteResponseSchema,
   type InteractiveSubmissionExecuteRequest,
   type InteractiveSubmissionExecuteResponse,
 } from '../../../schemas/api/interactive-submission';
-
 /** Execute an interactive submission that has been previously prepared and signed. */
 export const InteractiveSubmissionExecute = createApiOperation<
   InteractiveSubmissionExecuteRequest,
   InteractiveSubmissionExecuteResponse
 >({
   paramsSchema: InteractiveSubmissionExecuteRequestSchema,
+  responseSchema: InteractiveSubmissionExecuteResponseSchema,
   method: 'POST',
   buildUrl: (_params: InteractiveSubmissionExecuteRequest, apiUrl: string) =>
     `${apiUrl}/v2/interactive-submission/execute`,
-  buildRequestData: (params) => params,
+  buildRequestData: (params) => ({
+    ...params,
+    deduplicationPeriod: params.deduplicationPeriod ?? { Empty: {} },
+  }),
+  getFreshRetryIdentifier: (params) => params.submissionId,
 });

src/clients/ledger-json-api/operations/v2/interactive-submission/get-preferred-package-version.ts

@@ -1,5 +1,8 @@
 import { createApiOperation } from '../../../../../core';
-import { type GetPreferredPackageVersionResponse } from '../../../schemas/api';
+import {
+  GetPreferredPackageVersionResponseSchema,
+  type GetPreferredPackageVersionResponse,
+} from '../../../schemas/api';
 import {
   InteractiveSubmissionGetPreferredPackageVersionParamsSchema,
   type InteractiveSubmissionGetPreferredPackageVersionParams,
@@ -23,6 +26,7 @@ export const InteractiveSubmissionGetPreferredPackageVersion = createApiOperatio
   GetPreferredPackageVersionResponse
 >({
   paramsSchema: InteractiveSubmissionGetPreferredPackageVersionParamsSchema,
+  responseSchema: GetPreferredPackageVersionResponseSchema,
   method: 'GET',
   buildUrl: (params: InteractiveSubmissionGetPreferredPackageVersionParams, apiUrl: string) => {
     const url = new URL(`${apiUrl}/v2/interactive-submission/preferred-package-version`);

src/clients/ledger-json-api/operations/v2/interactive-submission/get-preferred-packages.ts

@@ -1,5 +1,5 @@
 import { createApiOperation } from '../../../../../core';
-import { type GetPreferredPackagesResponse } from '../../../schemas/api';
+import { GetPreferredPackagesResponseSchema, type GetPreferredPackagesResponse } from '../../../schemas/api';
 import {
   InteractiveSubmissionGetPreferredPackagesParamsSchema,
   type InteractiveSubmissionGetPreferredPackagesParams,
@@ -27,13 +27,10 @@ export const InteractiveSubmissionGetPreferredPackages = createApiOperation<
   GetPreferredPackagesResponse
 >({
   paramsSchema: InteractiveSubmissionGetPreferredPackagesParamsSchema,
+  responseSchema: GetPreferredPackagesResponseSchema,
   method: 'POST',
   requestSemantics: 'read',
   buildUrl: (_params: InteractiveSubmissionGetPreferredPackagesParams, apiUrl: string) =>
     `${apiUrl}/v2/interactive-submission/preferred-packages`,
-  buildRequestData: (params: InteractiveSubmissionGetPreferredPackagesParams) => ({
-    packageVettingRequirements: params.packageVettingRequirements,
-    synchronizerId: params.synchronizerId,
-    vettingValidAt: params.vettingValidAt,
-  }),
+  buildRequestData: (params: InteractiveSubmissionGetPreferredPackagesParams) => params,
 });

src/clients/ledger-json-api/operations/v2/interactive-submission/index.ts

@@ -1,7 +1,6 @@
-export * from './allocate-party';
-export * from './create-user';
 export * from './execute';
+export * from './execute-and-wait';
+export * from './execute-and-wait-for-transaction';
 export * from './get-preferred-package-version';
 export * from './get-preferred-packages';
 export * from './prepare';
-export * from './upload-dar';

src/clients/ledger-json-api/operations/v2/interactive-submission/prepare.ts

@@ -1,6 +1,7 @@
 import { createApiOperation } from '../../../../../core';
 import {
   InteractiveSubmissionPrepareRequestSchema,
+  InteractiveSubmissionPrepareResponseSchema,
   type InteractiveSubmissionPrepareRequest,
   type InteractiveSubmissionPrepareResponse,
 } from '../../../schemas/api/interactive-submission';
@@ -11,9 +12,23 @@ export const InteractiveSubmissionPrepare = createApiOperation<
   InteractiveSubmissionPrepareResponse
 >({
   paramsSchema: InteractiveSubmissionPrepareRequestSchema,
+  responseSchema: InteractiveSubmissionPrepareResponseSchema,
   method: 'POST',
   requestSemantics: 'read',
   buildUrl: (_params: InteractiveSubmissionPrepareRequest, apiUrl: string) =>
     `${apiUrl}/v2/interactive-submission/prepare`,
-  buildRequestData: (params) => params,
+  // Canton models these OpenAPI-optional fields as non-defaulted Scala values at the JSON boundary.
+  buildRequestData: (params) => ({
+    ...params,
+    synchronizerId: params.synchronizerId ?? '',
+    packageIdSelectionPreference: params.packageIdSelectionPreference ?? [],
+    ...(params.estimateTrafficCost === undefined
+      ? {}
+      : {
+          estimateTrafficCost: {
+            ...params.estimateTrafficCost,
+            expectedSignatures: params.estimateTrafficCost.expectedSignatures ?? [],
+          },
+        }),
+  }),
 });