feat(session): allow stream message IDs#64
Open
theadriann wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds optional
messageIdsupport toDroidSession.stream()by forwarding it throughMessageOptionsto the underlyingadd_user_messagerequest.Why
Some SDK consumers need a stable, client-generated id for the user message that starts a stream. Without this, they have to bypass
DroidSessionand call lower-level client APIs just to correlate later session notifications with the originating message.SDK impact
This is additive. Existing callers keep the same behavior when
messageIdis omitted. When provided, the SDK includes it inadd_user_message.params.messageId, matching the existing protocol field.What this enables
Higher-level
DroidSessionusers can track message identity for UI state, persistence, replay, and session operations without dropping down toDroidClient.addUserMessage().Testing
pnpm lintpnpm typecheckpnpm exec vitest run tests/session.test.tspnpm format:checkpnpm testpnpm build