Skip to content

fix: preserve target faction in rename events - #58

Closed
BriceFab wants to merge 1 commit into
FactionsU:mainfrom
BriceFab:fix-rename-event-target
Closed

BriceFab wants to merge 1 commit into
FactionsU:mainfrom
BriceFab:fix-rename-event-target

Conversation

@BriceFab

@BriceFab BriceFab commented Sep 24, 2026 •

Copy link
Copy Markdown

Fixes #57.

FactionRenameEvent currently derives its faction from the command sender, which causes administrative faction renames to expose the administrator's faction instead of the faction actually being renamed.

This change:

  • adds a constructor accepting the target Faction explicitly;
  • preserves the existing constructor for backwards compatibility;
  • passes the target faction when firing rename events;
  • adds regression tests for both administrative and regular faction renames.

@mbax

mbax commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

Fixed in ee89730

@mbax mbax closed this Sep 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FactionRenameEvent reports the sender's faction for administrative tag changes

2 participants