Skip to content

fix(checkpoint): address review on session TypedDict ownership (#8201) - #1

Merged
FOWEPJF255 merged 1 commit into
FOWEPJF255:feat/agent-executor-checkpoint-typeddict-8201from
ktz03:fix/8284-review-followup
Sep 11, 2026
Merged

FOWEPJF255 merged 1 commit into
FOWEPJF255:feat/agent-executor-checkpoint-typeddict-8201from
ktz03:fix/8284-review-followup

Conversation

@ktz03

@ktz03 ktz03 commented Sep 11, 2026

Copy link
Copy Markdown

Motivation & Context

Follow-up for microsoft#8284 review threads from @eavanvalkenburg and Copilot.

Description & Review Guide

  • Move the session payload TypedDict onto AgentSession as AgentSessionDict (to_dict() return type) so AgentExecutor does not maintain a second copy; keep AgentSessionCheckpointState as an alias for the existing public name.
  • Allow service_session_id: str | ServiceSessionId | None (structured mapping form).
  • Type on_checkpoint_restore(state: AgentExecutorCheckpointState) without the | dict[str, Any] union.
  • Sync agent_framework/__init__.pyi with the new root exports.

Happy to adjust naming if you prefer exporting only AgentSessionDict.

…wnership

- Define AgentSessionDict on AgentSession (to_dict return) so the shape is
  not duplicated in AgentExecutor; keep AgentSessionCheckpointState as alias.
- Include ServiceSessionId mapping in service_session_id.
- Type on_checkpoint_restore as AgentExecutorCheckpointState only.
- Sync root stub exports (__init__.pyi) with runtime __all__.
@FOWEPJF255

Copy link
Copy Markdown
Owner

Thanks for the follow-up on the TypedDict ownership review for microsoft#8284 / microsoft#8201.

I will review this branch on the fork and fold the changes into the upstream PR so the session payload type lives on AgentSession as discussed.

@FOWEPJF255
FOWEPJF255 merged commit a27cf51 into FOWEPJF255:feat/agent-executor-checkpoint-typeddict-8201 Sep 11, 2026
FOWEPJF255 pushed a commit that referenced this pull request Sep 14, 2026
…wnership (#1)

- Define AgentSessionDict on AgentSession (to_dict return) so the shape is
  not duplicated in AgentExecutor; keep AgentSessionCheckpointState as alias.
- Include ServiceSessionId mapping in service_session_id.
- Type on_checkpoint_restore as AgentExecutorCheckpointState only.
- Sync root stub exports (__init__.pyi) with runtime __all__.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants