Repository navigation
Safer APISIX defaults: ClusterIP gateway, etcd only when used, no catch-all route - #33
Merged
Merged
Conversation
The gateway Service took the default of the apisix chart, NodePort, so besides the Ingress that carries its host and TLS, the gateway answered plain HTTP on a port of every node, outside of anything the Ingress enforces. It is now a ClusterIP Service and is published through an Ingress. NodePort or LoadBalancer are still one value away. `externalTrafficPolicy` is left empty: apisix chart versions before 2.18 write it for every Service type, and the API server rejects it on a ClusterIP one. The integration tests reach the gateway on a fixed port of the node, so their deployment sets NodePort explicitly. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The chart deployed an etcd for APISIX by default, although its default standalone mode reads the routes from a ConfigMap and never connects to it. That etcd ran the unmaintained `bitnamilegacy/etcd:latest` image, without authentication, on an 8Gi volume, and held APISIX back with a wait-etcd init container. It is no longer deployed unless `apisix.etcd.enabled` is set. A release whose APISIX reads its configuration from etcd (a mode other than standalone, unless the role is traditional with `config_provider: yaml`) and has neither that etcd nor `apisix.externalEtcd.host` now fails to render, naming the values to set. Otherwise an upgrade from a version that deployed etcd by default would remove it and leave the gateway without routes. The example host the apisix chart ships in `externalEtcd.host` does not count as one. The chart lint renders a traditional deployment with its etcd as well (`ci/traditional-etcd-values.yaml`). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Every release got a route for every path (/*) to `my-broker:8080`, a Service that does not exist, checked against the `mySecuredService` service of the verifier. Requests that matched no route went through the OIDC flow and ended in an error from a missing upstream instead of a 404, and the gateway published a route nobody had configured. The route is now off unless `apisix.catchAllRoute.enabled` is set; `apisix.routes` publishes each service on its own host and paths. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Please apply exactly one of the following labels to the PR: 'patch', 'minor', 'major'. |
Mortega5
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three defaults of the chart published or ran things that a release does not use:
apisix.service.typeNodePort(the apisix chart's default)ClusterIPapisix.etcd.enabledtruefalseapisix.catchAllRoute.enabledtruefalseexternalTrafficPolicyis left empty because apisix chart versions before 2.18 write it for every type, and the API server rejects it on a ClusterIP Service.bitnamilegacy/etcd:latestwithout authentication, each on an 8Gi volume, and held APISIX back with await-etcdinit container. It is now deployed only whenapisix.etcd.enabledis set./*tomy-broker:8080, which does not exist, checked against the verifier'smySecuredService. Unmatched requests went through the OIDC flow and ended in an upstream error instead of a 404.Upgrades
APISIX reads its configuration from etcd in any mode other than standalone, unless the role is
traditionalwithconfig_provider: yaml. Such a release that relied on the old default would lose etcd on upgrade and its gateway would serve no routes. Instead, the chart now refuses to render it withoutapisix.etcd.enabledor anapisix.externalEtcd.hostof its own, and names both. The example host the apisix chart ships inexternalEtcd.hostdoes not count as one.On an upgrade of a standalone release, the etcd StatefulSet is removed but its PersistentVolumeClaims, one per replica (three by default), are kept.
kubectl delete pvc data-<release>-etcd-0 data-<release>-etcd-1 data-<release>-etcd-2removes them.A release that used the catch-all route sets
apisix.catchAllRoute.enabled: true, and one that reached the gateway through the NodePort setsapisix.service.type: NodePort. The integration tests do the latter, since they call the gateway on port 30080 of the node.Tests
helm lintand the kubeconform validation of the shared chart lint, with the defaults and withci/traditional-etcd-values.yaml(traditional mode with its etcd)etcd.enabled, with an external etcd, with traditional andconfig_provider: yaml(the integration tests), and in standalone. Checked with apisix chart 2.16.0 and 2.18.2