forms improvements - make form per event & add number input#367
Open
pigrammer3 wants to merge 8 commits intoFIRSTTeam102:masterfrom
Open
forms improvements - make form per event & add number input#367pigrammer3 wants to merge 8 commits intoFIRSTTeam102:masterfrom
pigrammer3 wants to merge 8 commits intoFIRSTTeam102:masterfrom
Conversation
…e some func sigs too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #362
mostly what this PR would do is change forms to happen per event instead of per year, so that organizations could change their forms over a season and not worry about affecting old data; this would also help when having some sort of inter-organization collaboration & data sharing in the future as they could have entirely different schemas in different events. I did limited testing locally but I don't really think that's enough as my local DB doesn't really have a lot of variety of data in it. Additionally, this change would require admins, whenever they want to scout a new event, to have to go in to the edit form area and submit the form which automatically is pulled from the latest event at that year; later it would probably be good to make this happen whenever you switch to a new event. This also could create some issues when comparing data across multiple events.
this PR includes a migration script which should pick reasonable events to set schemas to, which is also only tested on my limited local dataset.