Repository navigation
FEX: Implement support for CPUID faulting - #6104
Merged
Merged
Conversation
Sonicadvance1
marked this pull request as draft
November 5, 2026 03:37
Member
Author
|
I'll finish this post-release. |
Sonicadvance1
commented
Nov 5, 2026
Tests various instruction lengths to ensure it works robustly.
Sonicadvance1
marked this pull request as ready for review
November 5, 2026 23:12
Member
Author
|
Alright, remaining bug actually wasn't anything spooky. I just forgot to say that the CPUID OpcodeDispatcher actually sets RIP. |
lioncash
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a relatively new Linux feature from 2017. Supported on AMD CPUs since Zen 4 (2022) and Intel CPUs since Ivy Bridge (2012). So it's been a long time coming for AMD to catch up. I had been slowly working towards implementing this but finally pushed it over the edge. This will slow down our CPUID emulation slightly but having it supported is worth it.
Some test results from my AmpereOneA.
Before:
Before with const-prop disabled:
After:
TR7995WX for fun:
As seen most of the performance hit comes from the const-prop removal, but we actually manage to claw back a bit of the performance. The implementation is still faster than the threadripper which is kind of fun. Tested this with Proton with its CPUID emulation to ensure its working properly there but the unittest does what WINE does plus more.