Repository navigation
Read and write the index json on one rank only - #277
Merged
Merged
Conversation
`merge_index_files` had every rank open the consolidated index for writing, and `average_field_files` had every rank open the index for reading. Both are collective calls, so on a parallel filesystem this means N ranks writing the same path concurrently and N ranks reading the same file. Write on rank 0 and broadcast on read, matching what `index_files_from_folder` already does for the per-folder indices. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
adperezm
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having Claude pull in some fixes that I needed during my postprocessing.
In this case,
merge_index_fileshad every rank open the consolidated index file for writing (same withaverage_field_filesfor reading). Fix by write/reading on rank 0, matching whatindex_files_from_folderdoes.