Repository navigation
added an optional tolerance for the rst coordinates in interpolation - #273
Merged
Merged
Conversation
Collaborator
Author
|
almost forgot... acknowledging my best friends help on this (Claude Fable and Opus) |
Collaborator
|
Hi thanks! I will merge it but first I will do some modifications. Perhaps not today, but this week for sure :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The coordinates of the face points were different by 1 ULP in fp32 and the low tolerances on rst coordinates made some interpolation points that lied almost exactly on the face not belong to neither elements. This was observed mostly on larger boxes but also on the smaller ones depending on the grid...
This PR adds an optional rst tolerance (admittedly not the greatest way of solving the problem) which will help solve the issue such all points are now found.