ci(sign): keyless signing leg (default off) + zero-prod-contact rehearsal - #325
Draft
robinnsc wants to merge 1 commit into
Draft
ci(sign): keyless signing leg (default off) + zero-prod-contact rehearsal#325robinnsc wants to merge 1 commit into
robinnsc wants to merge 1 commit into
Conversation
…rsal The sign-image composite action gains a keyless input (Fulcio workflow-identity certificate, Rekor logged, additive to the keyed signature on the same tag-based .sig artifact) — default false, so merging changes no production behavior. A rehearsal workflow proves the whole path on real runners against a scratch GHCR package: flag set for keyless+tag-based storage, certificate identity captured from the signature itself (the strings verify docs must pin), artifact shape compatibility with every existing gate, verification by identity, and a wrong-identity negative control. Production callers flip keyless on only after repeated green rehearsals.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Draft — staged rollout; merging changes zero production behavior.
sign-imagecomposite action gains akeylessinput (defaultfalse): when enabled, cosign exchanges the job's OIDC token for ashort-lived Fulcio certificate bound to the workflow run's identity and
signs additively — the keyless signature lands as another layer on
the same tag-based
.sigartifact, next to the KMS signature, per therecorded dual-signing decision.
key-arnbecomes optional (empty skipsthe keyed leg — rehearsal use only).
keyless-rehearsalworkflow proves the entire path with zeroproduction contact: scratch image in a dedicated GHCR package, signed
through the production composite action, then — certificate identity
captured from the signature itself, artifact shape asserted against the
mirror/promote gate requirements, verification by identity, and a
wrong-identity negative control.
Infrastructure changes required
None. No AWS (KMS untouched; dual-signing keeps it), no new GitHub
environments or secrets: Fulcio needs
id-token: write(signing jobsalready carry it), Rekor reachability from runners is proven since v0.1.8.
The trust infrastructure is Sigstore's public instance — which is also the
honest caveat: keyless verification depends on Fulcio/Rekor availability
and TUF roots, which is why the KMS signature remains the air-gap answer.
Why keyless
Ends public-key distribution (verify by identity, not by PEM), and
resolves the documented one-key caveat: dev and postgres images are
signed by different workflows, so identity-based verification distinguishes
image tiers natively — something key-based verification cannot do.
Rollout plan (the high-confidence gate)
keyless-rehearsalrepeatedly (it is cheap andcredential-free). It empirically pins the cosign v3 flag set for
keyless + tag-based storage on real runners — the exact class of flag
interaction that produced the ECR storage-mode incident — and prints the
ACTUAL certificate identity strings.
admission-policy guidance (identity per workflow = per image tier).
keyless: 'true'inrelease-image/release-dev-image(separate trivial PR). First dual-signed releaseverifies both ways; nothing existing changes —
cosign verify --keycontinues to pass against the KMS layer, so the drift verifier, all
runbook procedures, and every published instruction remain valid.
Testing done
yaml.safe_loadon both files; the keyless step reuses the pinned,checksum-verified cosign install and the validated annotation handling.
is what the rehearsal exists to establish on real runners before any
production caller enables the flag. The action's keyless leg self-checks
(verify-by-identity) and the rehearsal adds the negative control, so a
wrong flag set fails loudly in rehearsal, not in a release.
Checklist
ADR / RFC: n/a — CI tooling; the signing-model decision (dual, additive) is already recorded in the release runbook.
Breaking changes
None. Default-off; the keyed signature and all existing verification paths are unchanged.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache License 2.0 and I agree to the Developer Certificate of Origin (DCO). See CONTRIBUTING.md for details.