Repository navigation
Upgrade react-native-web to 0.21.4 before RN 0.88 bump #104549
Copy link
Copy link
Open
Labels
EngineeringInternalRequires API changes or must be handled by Expensify staffRequires API changes or must be handled by Expensify staffTaskWeeklyKSv2KSv2
Description
Parent issue
Part of #101427 — must land before the main React Native 0.88 / Expo SDK 58 bump PR.
Background
Expo SDK 58 imports AssetRegistry straight from react-native. For example, expo-asset (Asset.ts and resolveAssetSource.ts) does import { AssetRegistry } from 'react-native'. On web, react-native resolves to react-native-web, and react-native-web only exports AssetRegistry from its root since 0.21.4. 0.21.2 and 0.21.3 do not export it.
main is on react-native-web 0.21.2, so the web build breaks as soon as SDK 58 lands. Expo SDK 58 bundles react-native-web ~0.21.4.
This is a patch bump inside 0.21.x, so it can land on the current RN 0.86 / Expo SDK 57 stack.
Scope
- Bump
react-native-web0.21.2→0.21.4in App. Mobile-Expensify does not depend onreact-native-web, so no HybridApp change is expected. - Rebase or remove the 12 patches under
patches/react-native-web/. They are all pinned to0.21.2in their filenames. Between0.21.2and0.21.4, upstream changedText,TextInput, theTouchable*components,ScrollView,Image,StyleSheet,createDOMPropsandVirtualizedList. Check these patches carefully:007+fix-scrollable-overflown-text(Text)010+fullstory-support(Text,TextInput,TouchableWithoutFeedback,View,createDOMProps)012+submitBehavior-support(TextInput)001,005,008,009,011(VirtualizedList)
- Update
patches/react-native-web/details.mdto match. - Check whether the
'react-native/Libraries/Image/AssetRegistry': falsealias inconfig/rsbuild/rsbuild.common.tsis still needed for@shopify/react-native-skiaon web.
Target
react-native-web@0.21.4(the version Expo SDK 58 bundles)
Acceptance criteria
-
import { AssetRegistry } from 'react-native'resolves on web -
npm installapplies everyreact-native-webpatch with no errors - Web and desktop build and run
- Lists (LHN, chat, Search) scroll as before, including nested and two direction scroll, with no overscroll recoil
- Multiline text truncation,
TextInputsubmit behavior, modals and FullStory masking work as before - Patch audit documented: keep, update, or remove
- No new JS console errors
Notes
- Keep this PR focused — do not include the RN / Expo version bump here
Issue Owner
Current Issue Owner: @shubham1206agraReactions are currently unavailable
Metadata
Metadata
Assignees
Labels
EngineeringInternalRequires API changes or must be handled by Expensify staffRequires API changes or must be handled by Expensify staffTaskWeeklyKSv2KSv2
Activity