Skip to content

Expense - Recipient page opens briefly when submitting to employer #104131

Open
Open
Expense - Recipient page opens briefly when submitting to employer#104131
Assignees
deetergpLukasMod
Labels
BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringOverdue

Description

@applause-bot
applause-bot
bot
opened on Oct 15, 2026

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.

Version Number: 9.5.10-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/78924844/folder/13176877/41237352/1865573394?sort=-identifier
Email or phone of affected tester (no customers): jsoidjndoiniodnsjojd@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Account does not have workspace.
  1. Go to staging.new.expensify.com
  2. Go to self DM.
  3. Create an expense.
  4. Click Submit to my employer.

Expected Result:

Recipient page will not open when submitting to employer.

Actual Result:

Recipient page opens briefly when submitting to employer.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

_To be ad

Bug7287406_1792084396206.1.mp4

ded by Applause Leads_

View all open jobs on GitHub

Applause Internal Information
Exported by: Chandana Kiran
Bug ID: 7287406

Issue OwnerCurrent Issue Owner: @LukasMod

Activity

  1. applause-bot
    added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 15, 2026
  2. gleitebr
    added this to #expensify-bugson Oct 15, 2026

  3. applause-bot commented on Oct 15, 2026

    @applause-bot
    applause-botBot
    on Oct 15, 2026
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/1a1827c61477715546c0a92a183863d3683276e662dd89f7fda8be5e9560dfdd

  4. melvin-bot
    assigned
    deetergp
    on Oct 15, 2026

  5. melvin-bot commented on Oct 15, 2026

    @melvin-bot
    melvin-botBot
    on Oct 15, 2026 – with Melvin Bot

    Triggered auto assignment to @deetergp (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  6. github-actions
    added
    Engineering
    HourlyKSv2
    on Oct 15, 2026

  7. melvin-bot commented on Oct 15, 2026

    @melvin-bot
    melvin-botBot
    on Oct 15, 2026 – with Melvin Bot

    💬 A slack conversation has been started in #expensify-open-source

  8. github-actions commented on Oct 15, 2026

    @github-actions
    github-actionsBot
    on Oct 15, 2026 – with GitHub Actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.

  9. MelvinBot commented on Oct 15, 2026

    @MelvinBot
    MelvinBot
    on Oct 15, 2026
    Contributor

    Deploy Blocker Analysis

    Likely cause (medium confidence): Bump Onyx to 3.0.117 (Expensify/App#98956), merged 2026-10-14.

    Recommendation: Revert #98956. If you can't revert, roll forward with one of these fixes:

    • App fix: write participants and reportID into the first draft Onyx.set, or wait for the merges before navigating.
    • Onyx fix: have useOnyx report loading on first mount whenever a merge is pending, even if the key is cached.

    I didn't reproduce this bug or watch the video. No App file in this flow changed during this deploy cycle, so the Onyx bump is the only staging change that affects its timing.

    How the flash happens
    1. With no workspace, the "Submit to my employer" button creates the draft expense with participants: [] using Onyx.set.
    2. createDraftWorkspaceAndNavigateToConfirmationScreen sets the workspace as recipient with async Onyx.merge calls. Then it navigates to the confirmation page right away.
    3. The confirmation page waits for the draft to load (withFullTransactionOrNotFound.tsx:98). In Onyx 3.0.117, useOnyx only reports loading when the key is not cached and a merge is pending: 
      const isLoading = !isOnyxInitialised() || (connectedKeyRef.current !== key && !isCached && OnyxUtils_1.default.hasPendingMergeForKey(key));
      The draft is already cached from the Onyx.set, so the page renders with participants: [].
    4. A manual expense with no participants auto-opens the recipient picker (IOURequestStepConfirmation.tsx:385-394). A moment later the merge lands and the picker closes. That's the flash.

    The PR description says "Loading is now tied to the first value rather than the first connect callback." I believe 3.0.116 kept the page loading until the merges applied, but I haven't checked the 3.0.116 source.

    This is a general change in loading behaviour. Any flow that runs Onyx.set, then Onyx.merge, then navigates may now render the pre-merge value for a frame. That's why I recommend a revert over a demotion.

    Ruled out: Fix import/no-cycle - part 16 (navigation refactor, same config), Keep split navigator state when navigating to the only sidebar screen on narrow layout (narrow layout only), and Fix: just used route not available in Reuse Route in offline mode (distance expenses only).

    Next Steps: Ask fabioh8010 (PR author) to confirm or revert. Reply with @MelvinBot <your feedback> to refine this analysis.

    view run

  10. LukasMod commented on Oct 16, 2026

    @LukasMod
    LukasMod
    on Oct 16, 2026
    Contributor

    I'm working on fix
    cc @fabioh8010

  11. cristipaval
    added
    DailyKSv2
    and removed
    DeployBlockerCashThis issue or pull request should block deployment
    HourlyKSv2
    on Oct 16, 2026

  12. cristipaval commented on Oct 16, 2026

    @cristipaval
    cristipaval
    on Oct 16, 2026
    Contributor

    Demoting, it doesn't block the user

  13. cristipaval
    assigned
    LukasMod
    on Oct 16, 2026
  14. melvin-bot
    added
    ReviewingHas a PR in review
    WeeklyKSv2
    and removed
    DailyKSv2
    on Oct 16, 2026

  15. LukasMod commented on Oct 16, 2026

    @LukasMod
    LukasMod
    on Oct 16, 2026
    Contributor

    Fix ready: #104192

  16. melvin-bot
    added
    DailyKSv2
    and removed
    ReviewingHas a PR in review
    WeeklyKSv2
    on Oct 21, 2026

  17. melvin-bot commented on Oct 21, 2026

    @melvin-bot
    melvin-botBot
    on Oct 21, 2026 – with Melvin Bot

    @deetergp @LukasMod

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.15-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

  18. melvin-bot
    added
    Overdue
    on Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringOverdue

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions