V2.5 def8#70
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates production configuration/scripts for CTA prod6 analysis runs, including expanded run coverage (zenith angles/NSB), new subarray definitions, and adjustments to XGBoost stereo analysis job generation to account for telescope multiplicity.
Changes:
- Expand batch execution in
CTA.runAllScripts.shto cover multiple zenith angles and both dark/moon NSB conditions. - Add new SouthAlpha subarray configurations with 3 LSTs.
- Update XGB stereo submission/analyse scripts to pass a maximum telescope multiplicity parameter and adjust high-multiplicity model selection; bump analysis/XGB date tags; add a maintenance changelog entry.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
setSoftwarePaths.sh |
Downgrades the “software directory not found” message to a warning (but still returns early). |
prod6/subArray.prod6.SouthAlpha.list |
Adds two new SouthAlpha array configurations (3 LST variants). |
docs/changes/70.maintenance.md |
Adds a short maintenance note about a multiplicity/XGB-related bugfix. |
CTA.runAnalysis.sh |
Updates ANADATE/XGBDATE tags to a newer analysis date. |
CTA.runAllScripts.sh |
Runs all scripts over additional zenith angles and NSB levels (dark + moon). |
analysis/CTA.XGBSTEREO.sub_analyse.sh |
Introduces computation of TELMAX and attempts to substitute it into generated qsub scripts. |
analysis/CTA.XGBSTEREO.qsub_analyse.sh |
Adds MAXTEL and changes logic for selecting a high-multiplicity model prefix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
38
to
42
| # high multiplicity events | ||
| OMINTEL=${MINTEL} | ||
| [ "$OMINTEL" -eq 2 ] && OMINTEL=23 | ||
| if [ "$MINTEL" -eq 2 ]; then | ||
| if [ "$MINTEL" -eq 2 ] && [ "$MAXTEL" -ne 3 ]; then | ||
| MODEL_OPTIONS+=( |
Comment on lines
+74
to
+76
| if [[ ! -d ${DATASET_DIR}/$SOURCE_ANALYSIS ]]; then | ||
| SOURCE_ANALYSIS=$TARGET_ANALYSIS | ||
| fi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.