Skip to content

feat(cluster-secret-store): optional namespace conditions on every store - #56

Merged
danielgines merged 1 commit into
mainfrom
feat/cluster-secret-store-conditions
Sep 30, 2026
Merged

danielgines merged 1 commit into
mainfrom
feat/cluster-secret-store-conditions

Conversation

@danielgines

Copy link
Copy Markdown
Member

A ClusterSecretStore without spec.conditions can be referenced from any namespace. For platform-secret-store that means an application namespace can read every platform secret the controller's identity can reach: the DNS token, the Grafana admin password. There was no way to restrict it through this chart.

This adds an optional conditions list, passed through verbatim as ESO spec.conditions, so namespaces, namespaceSelector and namespaceRegexes all work:

  • top-level conditions: the single platform-secret-store, for azure, aws and gcpsm;
  • stores[].conditions: per entry in multi-store mode, falling back to the top-level list;
  • vault.conditions: app-secret-store.

Additive. With the defaults (empty lists), helm template is byte-identical to main in six cases:

  • azure single;
  • azure multi;
  • aws single;
  • aws multi with Vault;
  • gcpsm single;
  • gcpsm with Vault.

With the lists set, the render was server-side dry-run against an ESO v2.9.0 CRD and accepted.

A ClusterSecretStore without spec.conditions is usable from any namespace,
so an application namespace can read every platform secret the controller's
identity reaches. Add top-level conditions (platform-secret-store, all
providers), stores[].conditions (multi-store, falls back to the top-level
list) and vault.conditions (app-secret-store), passed through as ESO
spec.conditions.

Defaults are empty lists: the render is byte-identical to v0.45.0.
@danielgines
danielgines merged commit e6eda52 into main Sep 30, 2026
5 checks passed
@danielgines
danielgines deleted the feat/cluster-secret-store-conditions branch September 30, 2026 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant