Repository navigation
feat(cluster-secret-store): optional namespace conditions on every store - #56
Merged
Merged
Conversation
A ClusterSecretStore without spec.conditions is usable from any namespace, so an application namespace can read every platform secret the controller's identity reaches. Add top-level conditions (platform-secret-store, all providers), stores[].conditions (multi-store, falls back to the top-level list) and vault.conditions (app-secret-store), passed through as ESO spec.conditions. Defaults are empty lists: the render is byte-identical to v0.45.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A ClusterSecretStore without
spec.conditionscan be referenced from any namespace. Forplatform-secret-storethat means an application namespace can read every platform secret the controller's identity can reach: the DNS token, the Grafana admin password. There was no way to restrict it through this chart.This adds an optional
conditionslist, passed through verbatim as ESOspec.conditions, sonamespaces,namespaceSelectorandnamespaceRegexesall work:conditions: the singleplatform-secret-store, forazure,awsandgcpsm;stores[].conditions: per entry in multi-store mode, falling back to the top-level list;vault.conditions:app-secret-store.Additive. With the defaults (empty lists),
helm templateis byte-identical tomainin six cases:azuresingle;azuremulti;awssingle;awsmulti with Vault;gcpsmsingle;gcpsmwith Vault.With the lists set, the render was server-side dry-run against an ESO v2.9.0 CRD and accepted.