Skip to content

fix(desktop): mount injected entries in the vertical navigation list - #20

Closed
chengzhiyi wants to merge 1 commit into
Ericwong5021:mainfrom
chengzhiyi:fix/vertical-navigation-entries
Closed

chengzhiyi wants to merge 1 commit into
Ericwong5021:mainfrom
chengzhiyi:fix/vertical-navigation-entries

Conversation

@chengzhiyi

Copy link
Copy Markdown

What changed

Mount the injected Board, Agents, and Projects buttons in the nearest vertical navigation list, alongside native button rows. Preserve the recovery-launcher anchor when present, avoid reordering owned entries during refresh, and regenerate the shared browser bundle.

Why

In Codex Desktop 26.928.31416 on macOS, the Home button is nested inside a horizontal flex row. ensureDesktopEntries() previously inserted all three entries into the button's immediate parent. They appeared beside Home and expanded the rail from 52px to 160px.

Reproduction: enable Better Codex 0.4.18 in this desktop shell, then inspect the left navigation rail. The expected layout is one icon per row. With this fix, the actual desktop rail is 52px wide and the three injected entries share the same x coordinate with separate y positions. Native button styles and the host application files are unchanged.

Verification

  • npm run build
  • npm run verify (includes npm test): 295 passed, 12 skipped
  • Injected browser suite: 10 passed, using Playwright with installed Chrome
  • better-codex doctor on the isolated source instance: runtime and injection ready, MCP configured
  • Packaging check: not applicable; no packaging or installer changes

The two new regression cases cover nested horizontal rows with and without a native recovery launcher, narrow layout, panel navigation, refresh deduplication, and launcher restoration on uninstall. Existing flat-navigation fixtures also pass.

Platform coverage

  • macOS Apple Silicon (macOS 26.0.1, Codex Desktop 26.928.31416)
  • macOS Intel
  • Windows x64

UI and privacy

  • Described the affected UI surface and measured before/after layout above
  • No private task content, conversation content, credentials, or logs included
  • No generated binaries, local databases, or unrelated files included

Notes for reviewers

This is limited to desktop rail mounting and its regression coverage. Local and Relay Web UI mounting remains unchanged. macOS Intel and Windows have not been manually verified. The tracked generated TypeScript bundle is included as required by the repository's bundle consistency check.

@chengzhiyi chengzhiyi closed this Oct 4, 2026
@chengzhiyi
chengzhiyi deleted the fix/vertical-navigation-entries branch October 4, 2026 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant