Skip to content

[gui] Move report filter group arrows to the left#4860

Open
gulyasgergely902 wants to merge 1 commit into
Ericsson:masterfrom
gulyasgergely902:arrange-report-filter-group-arrow
Open

[gui] Move report filter group arrows to the left#4860
gulyasgergely902 wants to merge 1 commit into
Ericsson:masterfrom
gulyasgergely902:arrange-report-filter-group-arrow

Conversation

@gulyasgergely902
Copy link
Copy Markdown
Collaborator

Arrows for report filter groups (Baseline, Compare To and Dates) are aligned to the right but simple filters arrows are on the left.

This change aligns all the arrows to the left. It also adds the separators to all groups.

Arrows for report filter groups (Baseline, Compare To and Dates) are
aligned to the right but simple filters arrows are on the left.

This change aligns all the arrows to the left. It also adds the separators
to all groups.
Copy link
Copy Markdown
Collaborator

@barnabasdomozi barnabasdomozi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently make dev_package and the GUI tests fail with the following error:

[webpack-cli] HookWebpackError: [eslint] web/server/vue-cli/src/components/Report/ReportFilter/ReportFilter.vue
  511:3  error  Unexpected console statement. Only these console methods are allowed: warn  no-console

In ReportFilter.vue, consider using console.warn() instead of console.error().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants