Skip to content

fix(navigation): clamp navigateViewGroup index before PageController.jumpToPage #2238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
cursor wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(navigation): clamp navigateViewGroup index before PageController.jumpToPage #2238

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions modules/ensemble/lib/framework/action.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,14 +168,19 @@ class NavigateViewGroupAction extends EnsembleAction {
ScreenController()
.navigateToScreen(context, screenName: screenName, pageArgs: payload);
} else if (viewIndex != null) {
final pageGroup = context.findAncestorWidgetOfExactType<PageGroup>();
final menuLen = pageGroup?.menu.menuItems.length ?? 0;
final resolvedIndex = menuLen > 0
? safeViewGroupPayloadIndex(viewIndex, menuLen)
: viewIndex;
if (payload != null) {
// TODO: this is wrong. Can't mutate the scope like this
scopeManager.dataContext.addDataContext(payload);
}
// TODO: refactor the below. Both are needed when reloadView=false, but only
// viewGroupNotifier is needed without. Doesn't make any sense
PageGroupWidget.getPageController(context)?.jumpToPage(viewIndex);
viewGroupNotifier.updatePage(viewIndex, payload: payload);
PageGroupWidget.getPageController(context)?.jumpToPage(resolvedIndex);
viewGroupNotifier.updatePage(resolvedIndex, payload: payload);
}
return Future.value(null);
}
Expand Down