Skip to content

Track explicit Snowflake SQL TRY_CAST without affecting cast fast paths - #165

Merged
osipovartem merged 2 commits into
df55-physical-udf-instancefrom
df55-explicit-try-cast-origin
Oct 25, 2026
Merged

osipovartem merged 2 commits into
df55-physical-udf-instancefrom
df55-explicit-try-cast-origin

Conversation

@osipovartem

@osipovartem osipovartem commented Oct 25, 2026 •

Copy link
Copy Markdown
Collaborator

Purpose

Preserve provenance of explicit Snowflake SQL TRY_CAST so Rustice can validate source types after parameter binding without changing internal DataFusion TryCast expressions.

Behavior

  • Mark only SQL TRY_CAST planned under the Snowflake dialect; generic SQL, SAFE_CAST, and planner-inserted casts remain unmarked.
  • Keep provenance non-semantic: type-only metadata propagation and same-type physical cast elision retain their fast paths.
  • Remove the marker from logical and physical result fields and formatted plans, including EXPLAIN output.

Verification

  • Focused unit tests cover SQL marking/display, logical output metadata, and physical same-type/metadata behavior.
  • cargo +1.99.0 fmt --all -- --check and git diff --check passed on the rebased branch.
  • Independent read-only review of the rebased four-file diff: approved, no blocking correctness, performance, API, or test findings.
  • #166 merged the RustFS CLI test repair and inherited CI-baseline fixes into the df55 base. This branch was rebased onto that base, dropping four duplicate CI commits; only the two functional commits remain. CI on the rebased head is running.
  • Full local builds remain deferred while the WSL host free-space guard is unmet. Rustice integration/routing tests are tracked in Embucket/rustice#1004.

@osipovartem
osipovartem force-pushed the df55-explicit-try-cast-origin branch from 0bc89d6 to b81c3a3 Compare October 25, 2026 17:24
@osipovartem
osipovartem merged commit 6770c7c into df55-physical-udf-instance Oct 25, 2026
37 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant