Repository navigation
Preserve recursive CTE work-table identifier case - #163
Merged
osipovartem merged 1 commit intoOct 23, 2026
Merged
Conversation
osipovartem
merged commit Oct 23, 2026
a0493b6
into
df55-physical-udf-instance
15 of 19 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
With
uppercase_unquoted_identifiers=true, recursive CTE planning reparses an already-normalized work-table name viaTableReference::from(String), lowercasing its qualifier. References such ascurrent_layer.component_idthen fail. The same reparse occurs when decoding recursive work-table scans from protobuf, including quoted mixed-case names.Change
Use
TableReference::bareat both scan construction points to preserve the normalized or quoted name. Add SQL planner coverage and executable protobuf round-trip coverage for uppercase unquoted and quoted mixed-case CTEs. The default identifier mode remains unchanged.Verification
cargo +1.97.0 test -p datafusion-sql --test sql_integration recursive_cte_preserves_normalized_and_quoted_namescargo +1.97.0 test -p datafusion-proto --test proto_integration(234 passed)cargo +1.97.0 clippy -p datafusion-proto -p datafusion-sql --all-targetscargo +1.97.0 fmt --all --check