Skip to content

Preserve OBJECT type for bound NULL in INSERT VALUES #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
osipovartem merged 1 commit into from
Oct 20, 2026
Merged

Preserve OBJECT type for bound NULL in INSERT VALUES #156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions datafusion/expr/src/logical_plan/plan.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2054,12 +2054,13 @@ impl LogicalPlan {
let (value, metadata) = param_values
.get_placeholders_with_values(&id)?
.into_inner();
if field.as_ref().is_some_and(|field| {
let object_field = field.as_ref().filter(|field| {
field
.metadata()
.get("embucket.snowflake_logical_type")
.is_some_and(|logical_type| logical_type == "OBJECT")
}) && !value.is_null()
});
if object_field.is_some() && !value.is_null()
&& !metadata.as_ref().is_some_and(|metadata| {
metadata
.inner()
Expand All @@ -2076,6 +2077,15 @@ impl LogicalPlan {
value.data_type()
);
}
let value = if value.is_null() {
if let Some(field) = object_field {
ScalarValue::try_new_null(field.data_type())?
} else {
value
}
} else {
value
};
Ok(Transformed::yes(Expr::Literal(value, metadata)))
} else {
Ok(Transformed::no(e))
Expand Down
14 changes: 12 additions & 2 deletions datafusion/sql/tests/sql_integration.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1002,8 +1002,18 @@ fn plan_insert_values_validates_bound_object_source() -> Result<()> {
.expect_err("bound scalar needs an explicit OBJECT conversion");
assert_contains!(err.to_string(), "to OBJECT; use TO_OBJECT");
}
plan.clone().with_param_values(vec![ScalarValue::Null])?;
plan.with_param_values(vec![ScalarValue::Utf8(None)])?;
for value in [ScalarValue::Null, ScalarValue::Utf8(None)] {
let bound = plan.clone().with_param_values(vec![value])?;
let mut input = &bound;
while !matches!(input, LogicalPlan::Values(_)) {
input = input
.inputs()
.into_iter()
.next()
.expect("INSERT VALUES input");
}
assert_eq!(input.schema().field(0).data_type(), &DataType::Utf8);
}
Ok(())
}

Expand Down
Loading