feat(quickdraw): add Outfits preset - #1930
Open
0x963D wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds an Outfits preset and picker category to Quickdraw. Each entry uses the saved outfit's name and icon, and outfits can also be dragged directly onto a Quickdraw slot.
Slots store the stable
outfitID, then resolve Blizzard's current player-facing index before updating the secure action. Outfit changes refresh those indexes throughTRANSMOG_OUTFITS_CHANGED.The secure button uses
action="change"so selecting the active outfit again does not toggle it off. Outfit entries also show Blizzard's outfit cooldown and Quickdraw's unusable tint during combat.Credit to @sgtoj for the original idea and implementation work in #1851. This alternate implementation keeps that player-facing feature while using the direct 12.1 outfit lookup, explicit non-toggle action, cooldown feedback, combat state, and drag-and-drop support.
How was it tested?
/euidevafter the complete in-game test with no reported errors.git diff --check.Screenshots
Before
Quickdraw's preset list did not include saved outfits.
After
The Outfits preset creates a menu from the character's saved outfits.
Checklist