Fix: Max Health Style not rendering when Absorb Style is disabled - #1917
Merged
EllesmereGaming merged 1 commit intoSep 2, 2026
Merged
Conversation
Bug: Issue: Raid Frames' Max Health Style overlay (e.g. for max-HP-reduction debuffs like the Den of Nalorakk curse) never rendered unless Absorb Style was also enabled, even though it's meant to be independent like Heal Absorb Style/Bar. Two separate early-return gates in UpdateAbsorb bailed out of the shared overlay frame whenever Absorb Style was off, without ever checking whether Max Health Style itself was on. Fix: Added a maxHealthOn flag checked by both gates so the function keeps painting when Max Health Style is enabled on its own. Also scoped the shield-absorb-specific bar painting (previously reached via fallthrough) behind styleOn so it doesn't re-show the unstyled shield-absorb overlay when Absorb Style is off.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: https://discord.com/channels/585577383847788554/1543885241318637619
Issue: Raid Frames' Max Health Style overlay (e.g. for max-HP-reduction debuffs like the Den of Nalorakk curse) never rendered unless Absorb Style was also enabled, even though it's meant to be independent like Heal Absorb Style/Bar. Two separate early-return gates in UpdateAbsorb bailed out of the shared overlay frame whenever Absorb Style was off, without ever checking whether Max Health Style itself was on.
Fix: Added a maxHealthOn flag checked by both gates so the function keeps painting when Max Health Style is enabled on its own. Also scoped the shield-absorb-specific bar painting (previously reached via fallthrough) behind styleOn so it doesn't re-show the unstyled shield-absorb overlay when Absorb Style is off.