feat(cdm): add min-stack threshold gate to bar glows - #1910
Closed
erickjmoreno wants to merge 1 commit into
Closed
Conversation
Adds an opt-in Require Min Stacks setting to Cooldown Manager Bar Glows. The glow only activates once the tracked buff reaches the configured stack count. Applications counts can be SECRET even in open-world content, so the threshold compare never touches Lua: a StatusBar window performs the compare C-side via SetValue, and its fill mask crops the native glow texture. Same technique as the existing per-icon Glow at Stacks feature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds an opt-in "Require Min Stacks" setting to Cooldown Manager Bar Glows. The glow only starts once the tracked buff/debuff reaches a configured stack/application count (2-99), instead of glowing on presence alone.
Applications counts can be a SECRET value even in open-world content, so the threshold compare never happens in Lua (any compare on a secret value hard-errors). Instead a one-unit StatusBar window
[threshold-1, threshold]performs the compare C-side viaSetValue, and a mask riding that fill's edge crops the native glow texture -- same technique already used by the per-icon "Glow at Stacks" feature.How was it tested?
ns._tickBlizzAuraStacks) is populated from the same sid/baseSID/linked resolution pass as the existing active cache, so it matches whatever spellID a Bar Glow entry is saved against.DualRowpattern and is disabled in Buff Missing mode (stacks don't apply there).Screenshots
N/A -- adds one settings row using the existing DualRow widget shape; no new visual style.
Checklist
HookScript/hooksecurefunconly, neverSetScripton Blizzard frames