ABR: Configurable, spec-agnostic Warlock wrong-demon reminder - #1909
Merged
EllesmereGaming merged 4 commits intoSep 2, 2026
Merged
Conversation
Lets any Warlock spec pick which demons count as correct for the active-pet reminder instead of hardcoding Felguard for Demonology only. A demon only counts while its summon spell is actually known, so an untalented Summon Felguard silently drops out rather than nagging for an unobtainable pet, and cosmetic Grimoire-of-* reskins (Wrathguard, Voidlord, Fel Imp, Observer, Shivarra/Incubus) no longer trip a false positive. The Missing Pet reminder can now be clicked to summon the chosen demon directly, or right-click to preview/cycle between several allowed demons without casting.
New literal L()/Lf() keys from the wrong-demon reminder work; Felguard drops off the static list since its only literal call site is now a variable lookup (still reachable at runtime through the pet table).
Covers the new Wrong Demon / Allowed Demons options and the Imp, Voidwalker, Felhunter, and Sayaad pet names (looked up officially by spell id; Felguard already had a translation). Drops the now-dead "Wrong Pet (Demo Lock)" entry the reminder no longer uses.
Barbiero
changed the title
Reuses the same pet-cycle logic as Missing Pet: left-click on a Wrong Demon reminder attempts to summon a correct demon, right-click previews/cycles through the allowed ones without casting. Both reminders share one cycle index, so cycling on either advances the same pointer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Reworks the Warlock "wrong pet" reminder in Aura/Buff Reminders:
pick, from a new Allowed Demons dropdown (Warlock Demons section),
which demons count as "correct" for their active pet.
untalented Summon Felguard silently drops out of the check instead of
nagging for a pet you cannot summon. The dropdown greys out Felguard
with an explanatory tooltip in that case, and reads "All" whether
nothing or everything is picked (both mean "never fires").
Observer, Shivarra/Incubus) no longer trigger a false "Wrong Demon".
demon directly. When more than one demon is allowed, right-click
previews/cycles through them without casting anything.
Reasoning
Demonology Warlocks are using Sayaad/Felhunter in certain situations nowadays, so Felguard isn't always the right choice. Expanding this behavior for more specs felt the natural thing to do.
How was it tested?
Tested in-game on live and confirmed working as expected. Also checked
with
luac -pand read through every changed code path by hand;creature-family and spell IDs were cross-checked against Wowhead and
the official CreatureFamily data table rather than guessed.
Screenshots
New Warlock Demons section
Select allowed demons granularly
Summon Felguard is disabled when it is not learned(either due to talent or due to not being a demonology warlock)
Summon pet for warlocks will now match "allowed pets" - right click to cycle between allowed demons
Having the wrong demon summoned shows a "Wrong Demon" string. Right click to cycle between allowed demons.
Checklist
{felguard=true}) reproduces the old Demonology-only behavior for existing users; Affliction/Destruction get no reminder by default since they won't have Summon Felguard known.HookScript/hooksecurefunconly, neverSetScripton Blizzard frames -- only the addon's own pooled SecureActionButtons are touched.