Fix: DK rune pips not honoring Border on Individual Pips - #1907
Merged
EllesmereGaming merged 1 commit intoSep 2, 2026
Merged
Conversation
Bug: Issue: Death Knight rune pips were hardcoded to always draw the outer secondary-frame border and never the per-pip border, ignoring the Border on Individual Pips setting that every other resource bar type respects. Fix: Removed the DEATHKNIGHT/runes special-casing so rune pips apply the per-pip border via ApplyBorder when Border on Individual Pips is enabled, and hide the outer border in that case like other pip types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: https://discord.com/channels/585577383847788554/1543549623241539656
Issue: Death Knight rune pips were hardcoded to always draw the outer secondary-frame border and never the per-pip border, ignoring the Border on Individual Pips setting that every other resource bar type respects.
Fix: Removed the DEATHKNIGHT/runes special-casing so rune pips apply the per-pip border via ApplyBorder when Border on Individual Pips is enabled, and hide the outer border in that case like other pip types.