Rename Dragonriding to Skyriding, with a settings migration - #1906
Open
mariusch wants to merge 1 commit into
Open
Rename Dragonriding to Skyriding, with a settings migration#1906mariusch wants to merge 1 commit into
mariusch wants to merge 1 commit into
Conversation
mariusch
force-pushed
the
fix/dragonriding-to-skyriding-rename
branch
2 times, most recently
from
September 1, 2026 20:37
1a24bff to
950fdf4
Compare
Blizzard renamed Dragonriding to Skyriding in patch 10.2.5 and made it an evergreen feature. The addon still used the old name in option labels, page names, tooltips, locale strings, and the Skyriding HUD's own module id. User-facing text: renames the Blizz UI Enhanced page, its toggles and tooltips, the visibility dropdown modes, the texture/font labels, and the matching keys in all seven locale files that carried translations. Locales: keys are renamed in place so existing translations survive. Where a file's own live Skyriding entries already used the current term but the renamed keys still carried the retired one, the values are aligned to that same in-file term -- deDE to Himmelsreiten, frFR to Vol draconique, zhCN to 驭空术 -- so those languages no longer render the old name under a Skyriding label. frFR also gains Hide when Skyriding Mounted, which it was missing, phrased from its own Hide when Mounted entry. koKR and ruRU are left for a native translator: koKR carries six competing variants and ruRU has no established modern term, so there is nothing in-file to align to. Also drops eleven entries that were dead or superseded, including a stale zhCN L["Dragon Riding Bar"] that would have collided with L["Skyriding Bar"]. Module id: the HUD's folder key moves from EllesmereUIDragonRiding to EllesmereUISkyriding, its file is renamed, and the vestigial EllesmereUIDragonRidingDB saved variable is replaced by EllesmereUISkyridingDB -- which also clears the old always-empty entry from every user's SavedVariables file. Two migrations carry the settings over, both running at parent ADDON_LOADED, well before the HUD reads its DB at PLAYER_LOGIN: skyriding_folder_rename_v1 re-keys the per-profile settings subtree under EllesmereUIDB.profiles[*].addons, and skyriding_synced_modules_rename_v1 re-keys the sync group in the global EllesmereUIDB.syncedModules, which is not reachable from profile scope. Profile strings exported under the old name still import, via a new per-entry legacySuffix that feeds the existing canon translation. Visibility mode values (show_dragonriding et al) and the EDR_ prefix are deliberately left alone: they are invisible to users, renaming them would require rewriting stored values across every module plus permanent import aliases for already-shared profile strings, and EDR_Cluster additionally keys saved unlock anchors. Comments describing those identifiers keep the old spelling so they still match the code they document.
mariusch
force-pushed
the
fix/dragonriding-to-skyriding-rename
branch
from
September 1, 2026 20:42
950fdf4 to
72c9d4c
Compare
mariusch
marked this pull request as ready for review
September 1, 2026 20:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Renames Dragonriding to Skyriding across the options and locale files, and migrates
existing settings onto the new module id. Nothing changes but the wording.
History
Blizzard renamed the feature in 10.2.5 and made it evergreen, so the old name has been
wrong for a while rather than just dated.
It also hid the settings. Searching the options for "skyriding" found the module but none
of its controls, because every row read
Enable Dragon Riding BarorWhen Dragonriding.The migration
Module data lives in
EllesmereUIDB.profiles[*].addons[folder], so the subtree moveswith one re-key. The child SV globals are vestigial,
NewDBwipes them each load.Two stores hold that folder key, in different scopes:
skyriding_folder_rename_v1addons.EllesmereUIDragonRidingskyriding_synced_modules_rename_v1syncedModules.EllesmereUIDragonRidingSync group membership sits on
EllesmereUIDBrather than in a profile, so profile scopenever reaches it. Without the second migration a synced HUD reads as unsynced and the old
key stays in SavedVariables.
Both run at parent
ADDON_LOADED, before the HUD reads its DB, and both delete the oldkey, so a re-run is a no-op. An optional
legacySuffixonADDON_DB_MAPkeeps profilestrings exported under the old name importing.
Worth flagging:
word in their own language under the renamed keys, so those values now follow the term
each file already used elsewhere (
Himmelsreiten,Vol draconique,驭空术). koKR hassix competing variants and ruRU none, so both fall back to English for now.
show_dragonridingandEDR_keep the old spelling. Both are stored values, notlabels: the visibility modes sit in already-shared profile strings import does not
translate, and
EDR_Clusterkeys saved unlock anchors. Renaming either orphans data.Eleven dead locale entries go too, and the module's
searchTermsdropsdragon ridingrather than keeping it as a synonym. frFR gains
Hide when Skyriding Mounted, which itwas missing. No new keys.
How was it tested?
In game on live. Existing profiles keep their Skyriding HUD settings through the folder
re-key.
All 29 files parse,
_keys.txtregenerates clean, every renamed key cross-checks againstlive source with no orphans left, and
addonsandsyncedModulesare the onlyfolder-keyed stores.
Screenshots
Checklist
ADDON_LOADED