Fix Sweeping Strikes / Whirlwind threshold config - #1904
Merged
EllesmereGaming merged 3 commits intoSep 2, 2026
Merged
Conversation
The WHIRLWIND_STACKS / SWEEPING_STRIKES engine-fed class bar routes its threshold coloring through ns.WC_Thresholds. That call passed _tsThreshCount unconditionally, but when the threshold entry is disabled (or a tracked buff is active) the resolver only nils _tsEntry -- _tsThreshCount still falls back to the legacy global sp.thresholdCount. The engine module then builds a range strip from any count > 0, so the overlay showed regardless of configuration. Gate the count on _tsEntry, matching every other threshold renderer in this function. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PcMbcZg9X5oNsnHBQNoVy7
Author
Author
Sweeping Strikes stacks to 18 with Broad Strokes, so the class/secondary resource bar threshold input clamped it to 10. Bump the pip/count cap to 20; bar-type (percent/value) and stagger caps are unchanged. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PcMbcZg9X5oNsnHBQNoVy7
Author
|
Additionally changed the max value for |
WC_Sync ran before _countText was created and styled, so the engine slot baked its count-text font from a nil fontstring and fell back to a hardcoded Expressway 12 OUTLINE. Move the call after the text setup so the configured font and size apply on /reload. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PcMbcZg9X5oNsnHBQNoVy7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Two related fixes for threshold configuration on the Warrior charge bars (Sweeping Strikes / Whirlwind Stacks).
1. Charge bar showed a threshold overlay when thresholds were disabled
These two powers have no Lua-comparable count, so their threshold coloring is routed through
ns.WC_Thresholdsand rendered by the engine module as a fill-masked range strip. InUpdateSecondaryResource()that call passed_tsThreshCountunconditionally:When the threshold entry is disabled (or a tracked buff is active) the resolver nils
_tsEntry, but_tsThreshCountstill falls back to the legacy globalsp.thresholdCount.HostThresholdsthen builds a single-band spec from anycount > 0, so the strip rendered regardless of configuration. Every other threshold renderer in that function already guards on_tsEntry; this path did not.Fix: pass the count only when the entry is enabled —
_tsEntry and _tsThreshCount or nil. Withcountnil and no bands,HostThresholdsclears the spec andStyleThresholdshides all strips.2. Threshold input clamped to 10
The count-based threshold input for the class/secondary resource bar clamped to 10, but Sweeping Strikes stacks to 18 with Broad Strokes. Raised the pip/count cap to 20; bar-type (percent/value) and stagger caps unchanged.
Testing
/reloadon Arms Warrior with the Sweeping Strikes secondary bar, thresholds disabled: overlay no longer appears; enabling thresholds still renders the strip.🤖 Generated with Claude Code