Add Combat Timer as a DataBar widget - #1902
Open
KechhaTV wants to merge 4 commits into
Open
Conversation
added CombatTimer defaults
added Logic for combatTimer dataBar
added "show only in combat" toggle for combat timer DataBar and EST_LEN entry for combatTimer DataBar
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a new Combat Timer widget to the DataBars module.
The timer uses Blizzard's Damage Meter session data to display the current combat duration independently of the EllesmereUI Damage Meters module. It uses a combat-only heartbeat to keep the displayed duration updated, following the same approach as the existing Standalone Combat Timer in the Damage Meter module.
This brings the existing Combat Timer functionality to DataBars while allowing it to benefit from the DataBar system's existing layout, styling, and customization options.
How was it tested?
Screenshots
Checklist
This does not fully apply to the DataBar implementation. Once the Combat Timer widget is added to a DataBar, its event frame is created and the relevant Damage Meter events are registered. The refresh heartbeat itself is only active while in combat and is stopped immediately when leaving combat. When the widget is not enabled/used, it has no associated events, polling, or update work.
This does not apply to this implementation. The Combat Timer intentionally follows the same update approach as the existing Standalone Combat Timer in the Damage Meter module. The purpose of this PR is to replicate that functionality as a DataBar widget, while making it available within the DataBar system for increased customization and integration with existing DataBar styling and layout options.
HookScript/hooksecurefunconly, neverSetScripton Blizzard frames