Skip to content

Fix Assisted Highlight glow customization - #1831

Open
Llusty wants to merge 1 commit into
EllesmereGaming:mainfrom
Llusty:fix/assisted-highlight-glow
Open

Fix Assisted Highlight glow customization#1831
Llusty wants to merge 1 commit into
EllesmereGaming:mainfrom
Llusty:fix/assisted-highlight-glow

Conversation

@Llusty

@Llusty Llusty commented Aug 29, 2026

Copy link
Copy Markdown

Summary

Add opt-in Assisted Highlight glow customization to Action Bars while preserving the existing EUI Assisted Highlight behavior and settings.

This update is now based on v9.1.5 and addresses the performance/settings concerns raised in review.

Changes

  • Keep the existing Assisted Highlight options:
    • Default (Blizzard)
    • Glow Ring
    • Button Overlay
    • Ring + Overlay
    • Overlay Opacity
    • Assisted Highlight Outset
  • Add the Custom Proc Glow styles to the existing Assisted Highlight dropdown as optional choices.
  • Add an independent Assisted Highlight color setting.
  • Add independent Class Color support for custom Assisted Highlight glows.
  • Keep Assisted Highlight settings fully separate from Custom Proc Glow:
    • assistGlowType
    • assistGlowColor
    • assistGlowUseClassColor
  • Preserve the existing assistGlowStyle setting and its default behavior for existing users.
  • Add a dedicated Assisted Highlight preview.

Performance / compatibility

Custom Assisted Highlight glows are purely opt-in.

Existing users continue to use the previous Assisted Highlight path unless they explicitly select one of the new custom glow types.

The custom glow path is change-guarded before calling StopAllGlows() and starting a new procedural glow. The guard checks the active glow type, button size, glow color, and wrapper state.

As a result, the rate-limited Assisted Highlight rescan does not restart the procedural animation when nothing has changed.

The existing Blizzard/EUI highlight path remains separate and does not use the procedural custom-glow engine.

Behavior

Custom Proc Glow and Assisted Highlight use independent settings.

Changing:

procGlowType / procGlowColor / procGlowUseClassColor

does not change:

assistGlowType / assistGlowColor / assistGlowUseClassColor

and vice versa.

Switching back from a custom Assisted Highlight glow restores the selected legacy/Blizzard Assisted Highlight behavior.

Testing

The implementation was previously tested in-game on v9.1.3 with:

  • Default (Blizzard)
  • Glow Ring
  • Button Overlay
  • Ring + Overlay
  • Custom Assisted Highlight glow types
  • Custom colors
  • Class colors
  • Overlay opacity
  • Assisted Highlight outset
  • Switching between legacy and custom glow modes
  • Independence from Custom Proc Glow

The same Assisted Highlight commit has now been cleanly rebased onto v9.1.5 without conflicts or additional unrelated changes.

@EllesmereGaming
EllesmereGaming marked this pull request as ready for review August 30, 2026 18:31
@Llusty
Llusty force-pushed the fix/assisted-highlight-glow branch from 4886c28 to 66ea494 Compare August 31, 2026 18:33
@Llusty
Llusty force-pushed the fix/assisted-highlight-glow branch from 66ea494 to 9ca4fde Compare September 1, 2026 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant