Fix Assisted Highlight glow customization - #1831
Open
Llusty wants to merge 1 commit into
Open
Conversation
EllesmereGaming
marked this pull request as ready for review
August 30, 2026 18:31
Llusty
force-pushed
the
fix/assisted-highlight-glow
branch
from
August 31, 2026 18:33
4886c28 to
66ea494
Compare
Llusty
force-pushed
the
fix/assisted-highlight-glow
branch
from
September 1, 2026 18:42
66ea494 to
9ca4fde
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add opt-in Assisted Highlight glow customization to Action Bars while preserving the existing EUI Assisted Highlight behavior and settings.
This update is now based on v9.1.5 and addresses the performance/settings concerns raised in review.
Changes
assistGlowTypeassistGlowColorassistGlowUseClassColorassistGlowStylesetting and its default behavior for existing users.Performance / compatibility
Custom Assisted Highlight glows are purely opt-in.
Existing users continue to use the previous Assisted Highlight path unless they explicitly select one of the new custom glow types.
The custom glow path is change-guarded before calling
StopAllGlows()and starting a new procedural glow. The guard checks the active glow type, button size, glow color, and wrapper state.As a result, the rate-limited Assisted Highlight rescan does not restart the procedural animation when nothing has changed.
The existing Blizzard/EUI highlight path remains separate and does not use the procedural custom-glow engine.
Behavior
Custom Proc Glow and Assisted Highlight use independent settings.
Changing:
procGlowType/procGlowColor/procGlowUseClassColordoes not change:
assistGlowType/assistGlowColor/assistGlowUseClassColorand vice versa.
Switching back from a custom Assisted Highlight glow restores the selected legacy/Blizzard Assisted Highlight behavior.
Testing
The implementation was previously tested in-game on v9.1.3 with:
The same Assisted Highlight commit has now been cleanly rebased onto v9.1.5 without conflicts or additional unrelated changes.