Minimap: unify text sizing on one Text Size (px) control - #1808
Open
tough-griff wants to merge 2 commits into
Open
Minimap: unify text sizing on one Text Size (px) control#1808tough-griff wants to merge 2 commits into
tough-griff wants to merge 2 commits into
Conversation
tough-griff
force-pushed
the
minimap-text-font-size
branch
from
August 29, 2026 14:43
2e84779 to
6c9a1f0
Compare
Clock, zone, coordinates and the FPS/MS readout each resized through a different mechanism -- a 0.5-2.0 "Scale" multiplier applied with SetScale on the host frame, plus the FPS readout carrying its own text-size slider on top of a scale. Replace all four with a single 8-30px Text Size slider applied via ApplyMinimapFont, matching the instance-difficulty control, and drop the fpsScale multiplier. - clockScale / locationScale / coordsScale -> clockSize / locationSize / coordsSize; fpsScale removed (fpsTextSize stays) - clock and zone edge-boxes now size to their text - dead _G._EBS_* globals (only used to live-SetScale from the options) removed - migration minimap_text_scale_to_font_size_v1 seeds the new *Size keys from the old scales (clock/zone x10, coords x11; fpsScale folded into fpsTextSize), clamped 8-30, so no minimap changes size Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PcbTBmdnc5d7ZXcLwVvGqe
SetScale on the clock/zone/coords/FPS host frame also multiplied that frame's SetPoint offsets, so a user's saved X/Y Offset was rendered in scaled space. Dropping to font size alone would shift any element that ran a scale other than 1.0. Fold the scale into the raw offset keys (clockOffsetX/Y, locationOffsetX/Y, coordsBelowOffsetX/Y, fpsOffsetX/Y), clamped to the slider range. The base map-edge inset was scaled too and is not compensated -- ~1px at the old 1.15 default, only visible for extreme scales. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PcbTBmdnc5d7ZXcLwVvGqe
tough-griff
force-pushed
the
minimap-text-font-size
branch
from
August 31, 2026 18:05
6c9a1f0 to
38f91e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Unifies the five minimap text elements — clock, zone, coordinates, FPS/MS, and instance difficulty — onto a single Text Size slider (8–30 px), applied through
ApplyMinimapFontthe way the difficulty readout already was.clockScale/locationScale/coordsScale→clockSize/locationSize/coordsSize. The FPS readout's separatefpsScalemultiplier is removed; its existingfpsTextSizeis now the only control._G._EBS_*globals that only existed so the old sliders could live-SetScale, plus the hard-coded font sizes at fontstring creation.Migration
minimap_text_scale_to_font_size_v1(profile scope) keeps every existing UI looking identical:*Sizekey fromold scale × the size that scale multiplied(clock/zone 10, coords 11;fpsScalefolded intofpsTextSize), clamped 8–30SetScalealso multiplied each frame's anchor offsets, so a saved X/Y Offset was rendered in scaled space — the migration folds the old scale intoclockOffsetX/Y,locationOffsetX/Y,coordsBelowOffsetX/Y,fpsOffsetX/YtooNet effect: existing minimaps keep their current text size and position; the controls just read in pixels now.
Closes #1806
How was it tested?
Changes applied against AtrocityUI profile, small adjustments were made since I'm running Ultrawide 1440p and wanted to size up my fonts. That's what inspired this change.
Screenshots
before, trying to increase size:
immediately after migration
1px adjustments after calculations:
Checklist
SetSizeon an addon-owned box inside an existing update tick🤖 Generated with Claude Code