fix(raidframes): fix absorb texture tiling - #1802
Open
manaste wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes a bug where absorb texture tiling does not work as expected. The texture is stretched instead of being repeated.
The easiest way to reproduce this is to replace
striped-thick.pngwith a smaller 32×32 version for testing:The result is:
This apparently happens because
StatusBar:SetStatusBarTexturedoes not set the texture's wrap mode toCLAMP. However,TextureBase:SetHorizTileandTextureBase:SetVertTilerequire the corresponding dimension's wrap mode to beREPEATfor tiling to work.This PR introduces a helper function to work around this limitation. The function calls
TextureBase:SetTexturewith the appropriate wrap mode on the status bar's texture before callingTextureBase:SetHorizTileandTextureBase:SetVertTile.Interestingly, this issue does not occur on unit frames, and I don't know why. No corresponding fix is required there.
How was it tested?
Tested on the live 12.1 client, build 9.0.7.
striped-thick.pngtexture.Checklist
HookScript/hooksecurefunconly, neverSetScripton Blizzard frames