Fix and rework the Important Cast Glow on enemy nameplates - #1779
Open
vcherneny wants to merge 1 commit into
Open
Fix and rework the Important Cast Glow on enemy nameplates#1779vcherneny wants to merge 1 commit into
vcherneny wants to merge 1 commit into
Conversation
The glow overlay covered the cast bar only, but the spell icon is a child of the bar anchored outside its edge, so the border ran down the icon's edge. It now spans the union of the two, with the vertical edges following whichever is taller. The measured size joins the restart cache key, since the FlipBook and shine engines size themselves once at start. Styles built from square action-button art smear when scaled onto a long bar. The list now offers only styles that hold their shape at any aspect: Pixel Glow, Auto-Cast Shine, Blizzard's own bar-authored indicator, and two new EUI edge glows drawn from primitives (nested outlines under a squared falloff, no art). Action Button Glow, GCD, Modern WoW Glow and Classic WoW Glow are dropped from THIS list only and remain in the aura lists, where the frames are square. Glow Size in the cog trims the effect in or out: where the border sits and how far the halo bleeds past the bar are the same dial pulled opposite ways, and which end looks right depends on bar width. The cog now opens for every style, with the Pixel-only rows greying out. The preview moves from a swatch beside the dropdown onto the nameplate preview, behind an eye toggle matching the absorb and target-glow previews on the same page. It renders through the same union rule and stored options as the real plate, so the two cannot disagree. np_important_cast_glow_drop_button_art_v1 re-points saved styles: removing entries mid-list renumbers what follows, so without it anyone on Auto-Cast Shine would silently become Pixel Glow. Version-guarded, as a renumbering is not self-idempotent. Default is still Pixel Glow and the new styles are appended after the survivors, so nothing changes for anyone who does not open the dropdown. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up PR after #1779
What does this PR do?
1. Glow border cut through the cast spell icon. The overlay was
SetAllPoints(self.cast), but the icon is a child of the bar anchored outside itsedge. It now spans the union of bar + icon, vertical edges following whichever is
taller. Measured size joins the restart cache key (FlipBook/Auto-Cast size
themselves once at start).
2. Square action-button art smears on a long bar. The list now offers only
styles that hold their shape at any aspect: Pixel Glow, Auto-Cast Shine,
Blizzard's own bar art, and two new EUI edge glows. Action Button Glow, GCD,
Modern WoW Glow and Classic WoW Glow are dropped from this list only — they
stay in the aura lists, where frames are square.
3. New styles. Blizzard Important Cast draws
ui-hud-nameplates-importantcastwith Blizzard's own outsets and a quickerImportantCastFlashAnim. Soft Bloom / Pulse Border use no art: nestedrectangle outlines under a squared falloff, correct at any aspect by construction,
one C-side AnimationGroup driving the pulse.
4. Glow Size (cog) trims the effect in or out — border placement and halo
bleed are the same dial pulled opposite ways, and the right end depends on bar
width. Default 0 = no change. The cog now opens for every style, Pixel-only rows
greying out.
Preview moves from a 26px swatch onto the nameplate preview, behind an eye
toggle matching the absorb/target-glow previews on this page. It renders through
the same union rule and stored options as the real plate.
Migration
np_important_cast_glow_drop_button_art_v1re-points saved styles —removing mid-list entries renumbers what follows, so without it anyone on
Auto-Cast Shine silently becomes Pixel Glow. Action Button → Pixel Glow; GCD,
Modern, Classic → Soft Bloom. Version-guarded, as renumbering is not
self-idempotent.
Two calls worth your view: this relaxes the preview's documented "no glow, no
added effects" rule, and it removes four styles from a shipped list. Happy to
revert either.
How was it tested?
Client 12.1.0.69497.
Offline: migration run against real SavedVariables and
(version guard holds). Style indices verified to resolve to the correctly named
engine entry. Parse clean, ASCII only,
_keys.txtunchScreenshots
glow-demo.mp4
Checklist
Pixel Glow; new styles appended after the survivors.
LoD panel open.
AnimationGroups. No OnUpdate, events, hooks or timers.
the passes above.