Skip to content

Feat/resource buff dim - #1767

Open
asdfractal wants to merge 4 commits into
EllesmereGaming:mainfrom
asdfractal:feat/resource-buff-dim
Open

Feat/resource buff dim#1767
asdfractal wants to merge 4 commits into
EllesmereGaming:mainfrom
asdfractal:feat/resource-buff-dim

Conversation

@asdfractal

@asdfractal asdfractal commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

  • Add buff manager indicator option - frame dim. This darkens a frame when a buff is present.
  • Add holy bulwark to buff list
  • Add power bar buff recolour (matches resource bar implementation)

How was it tested?

Tested in raid and m+

Screenshots

Frame dim:
image
image

Power bar colour:
image

Checklist

  • New settings default OFF (no behavior change without opt-in)
  • Zero cost while disabled: no events registered, no polling, no hooks doing work, no frames built
  • Cheap while enabled: event-driven (no polling, no timer-based logic, no per-frame allocations)
  • No writes onto Blizzard-owned frames (weak-table pattern used); HookScript/hooksecurefunc only, never SetScript on Blizzard frames
  • Tested in-game on live; no version gates or pre-Midnight APIs added

@asdfractal
asdfractal force-pushed the feat/resource-buff-dim branch 2 times, most recently from 65794ea to ed81410 Compare September 2, 2026 10:25
@asdfractal
asdfractal force-pushed the feat/resource-buff-dim branch from ed81410 to 6dae8e4 Compare September 2, 2026 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant