Skip to content

[bugfix] Fix Vault font/icon coloring & Character Screen fonts - #1740

Open
lolswirl wants to merge 4 commits into
EllesmereGaming:mainfrom
lolswirl:main
Open

[bugfix] Fix Vault font/icon coloring & Character Screen fonts#1740
lolswirl wants to merge 4 commits into
EllesmereGaming:mainfrom
lolswirl:main

Conversation

@lolswirl

@lolswirl lolswirl commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Applies global/module settings to Character Sheet and Great Vault window skins
Also fixes the coloration of the default "white" on the icon borders of great vault items to their rarity

How was it tested?

Live on 12.1.0.69497

Screenshots

Settings:
image

Character Sheet

Before:
image

After:
image

Great Vault

Before:
image

After:
image

Different settings

Settings:
image
image
image

item coloration fix:
image

Checklist

  • New settings default OFF (no behavior change without opt-in)
  • Zero cost while disabled: no events registered, no polling, no hooks doing work, no frames built
  • Cheap while enabled: event-driven (no polling, no timer-based logic, no per-frame allocations)
  • No writes onto Blizzard-owned frames (weak-table pattern used); HookScript/hooksecurefunc only, never SetScript on Blizzard frames
  • Tested in-game on live; no version gates or pre-Midnight APIs added

@lolswirl lolswirl changed the title [bugfix] Apply global/module font to Character Select & Great Vault [bugfix] Fix Vault font/icon coloring & Character Screen fonts Aug 25, 2026
@EllesmereGaming

Copy link
Copy Markdown
Owner

added the color fix for great vault items but the rest is a bit more complex that I need some more time to work on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants