Skip to content

Add e2e_needs_sandbox labeler support for local processor sandbox - #32

Merged
tdesai-eightfold merged 5 commits into
masterfrom
feature/add-needs-local-processor-support
Apr 22, 2026
Merged

tdesai-eightfold merged 5 commits into
masterfrom
feature/add-needs-local-processor-support

Conversation

@tdesai-eightfold

@tdesai-eightfold tdesai-eightfold commented Mar 2, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Adds labeler support for the new e2e_needs_sandbox comment form introduced in vscode#100917.

  • e2e_needs_sandbox (and region/time/app variants) now trigger the same sandbox labels as needs_sandbox
  • The e2e_ prefix signals the GitHub bot to start a local processor alongside the sandbox
  • Updated script header to document e2e_needs_sandbox as a supported command

Supported comment forms

Comment Label added
e2e_needs_sandbox sandbox
e2e_needs_sandbox:eu sandbox :eu:
e2e_needs_sandbox:10:taPwa sandbox
e2e_needs_sandbox:3.13 sandbox:3.13

@github-actions

github-actions Bot commented Apr 22, 2026 •

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Files

None

Tanish Desai added 2 commits April 22, 2026 11:43
@tdesai-eightfold tdesai-eightfold changed the title _processor support added in needs_sandbox Add e2e_needs_sandbox labeler support for local processor sandbox Apr 22, 2026
@tdesai-eightfold

tdesai-eightfold commented Apr 22, 2026 •

Copy link
Copy Markdown
Contributor Author

Regression Test Results — OLD (master) vs NEW (branch)

Total: 106 | ✅ PASS: 106 | ❌ FAIL: 0

No regressions. All old cases (positive + negative) behave identically on the new branch. Only intentional changes:

  • needs_sandbox:...:_processor no longer matches (dropped — processor now lives on e2e_needs_sandbox)
  • e2e_needs_sandbox variants added with parity to needs_sandbox
Full results table (click to expand)
Comment OLD output NEW output Status
needs_sandbox sandbox sandbox ✅
needs_sandbox sandbox sandbox ✅
needs_sandbox\t (trailing tab) none none ✅
needs_sandbox (trailing double space) sandbox sandbox ✅
needs_sandbox:1 sandbox sandbox ✅
needs_sandbox:10 sandbox sandbox ✅
needs_sandbox:100 sandbox sandbox ✅
needs_sandbox:0.5 sandbox sandbox ✅
needs_sandbox:1.5 sandbox sandbox ✅
needs_sandbox:10. sandbox sandbox ✅
needs_sandbox:dev sandbox sandbox ✅
needs_sandbox:taPwa sandbox sandbox ✅
needs_sandbox:TA sandbox sandbox ✅
needs_sandbox:app1,app2 sandbox :australia: sandbox :australia: ✅
needs_sandbox:10:taPwa sandbox sandbox ✅
needs_sandbox:10:taPwa,navBar,getHelp sandbox sandbox ✅
needs_sandbox:dev:taPwa sandbox sandbox ✅
needs_sandbox:eu sandbox :eu: sandbox :eu: ✅
needs_sandbox:ca sandbox :maple_leaf: sandbox :maple_leaf: ✅
needs_sandbox:gov sandbox :classical_building: sandbox :classical_building: ✅
needs_sandbox:uae sandbox :united_arab_emirates: sandbox :united_arab_emirates: ✅
needs_sandbox:wu sandbox :us: sandbox :us: ✅
needs_sandbox:ap sandbox :australia: sandbox :australia: ✅
needs_sandbox:eu:10 sandbox :eu: sandbox :eu: ✅
needs_sandbox:ca:1.5 sandbox :maple_leaf: sandbox :maple_leaf: ✅
needs_sandbox:gov:dev sandbox :classical_building: sandbox :classical_building: ✅
needs_sandbox:uae:10:taPwa sandbox :united_arab_emirates: sandbox :united_arab_emirates: ✅
needs_sandbox:wu:10:taPwa,navBar sandbox :us: sandbox :us: ✅
needs_sandbox:ap:dev:taPwa sandbox :australia: sandbox :australia: ✅
needs_sandbox:eu:taPwa sandbox :eu: sandbox :eu: ✅
needs_sandbox:3.13 none none ✅
needs_sandbox:3.13:eu none none ✅
needs_sandbox:3.13:ca none none ✅
needs_sandbox:3.13:gov none none ✅
needs_sandbox:3.13:uae none none ✅
needs_sandbox:3.13:wu none none ✅
needs_sandbox:3.13:ap none none ✅
needs_sandbox:3.13:10 none none ✅
needs_sandbox:3.13:dev none none ✅
needs_sandbox:3.13:eu:10 none none ✅
needs_sandbox:3.13:eu:10:taPwa none none ✅
needs_sandbox:3.13:taPwa none none ✅
needs_sandbox:_processor sandbox none ✅ (intentional)
needs_sandbox:10:_processor sandbox none ✅ (intentional)
needs_sandbox:taPwa:_processor sandbox none ✅ (intentional)
needs_sandbox:eu:_processor sandbox :eu: none ✅ (intentional)
needs_sandbox:eu:10:_processor sandbox :eu: none ✅ (intentional)
needs_sandbox:eu:10:taPwa:_processor sandbox :eu: none ✅ (intentional)
needs_sandbox:ap:dev:_processor sandbox :australia: none ✅ (intentional)
needs_sandbox:3.13:_processor none none ✅
needs_sandbox:3.13:eu:_processor none none ✅
needs_sandbox:3.13:10:taPwa:_processor none none ✅
empty none none ✅
space none none ✅
needs_sandbo none none ✅
needs_sandboxx none none ✅
xneeds_sandbox none none ✅
please needs_sandbox none none ✅
needs_sandbox extra none none ✅
needs_sandbox foo none none ✅
needs_sandbox: none none ✅
needs_sandbox:: none none ✅
needs_sandbox:eu: none none ✅
needs_sandbox:abc!def none none ✅
needs_sandbox:10.5.5 none none ✅
needs_sandbox:fr sandbox sandbox ✅ (fr treated as app name)
needs_sandbox:EU sandbox sandbox ✅ (uppercase treated as app name)
stop_sandbox none none ✅
shipit none none ✅
needs_ci none none ✅
needs_sandbox! none none ✅
needs_sandbox.eu none none ✅
e2e_needs_sandbox none sandbox ✅ (new)
e2e_needs_sandbox none sandbox ✅ (new)
e2e_needs_sandbox:1 none sandbox ✅ (new)
e2e_needs_sandbox:10 none sandbox ✅ (new)
e2e_needs_sandbox:1.5 none sandbox ✅ (new)
e2e_needs_sandbox:dev none sandbox ✅ (new)
e2e_needs_sandbox:taPwa none sandbox ✅ (new)
e2e_needs_sandbox:10:taPwa none sandbox ✅ (new)
e2e_needs_sandbox:10:taPwa,navBar none sandbox ✅ (new)
e2e_needs_sandbox:eu none sandbox :eu: ✅ (new)
e2e_needs_sandbox:ca none sandbox :maple_leaf: ✅ (new)
e2e_needs_sandbox:gov none sandbox :classical_building: ✅ (new)
e2e_needs_sandbox:uae none sandbox :united_arab_emirates: ✅ (new)
e2e_needs_sandbox:wu none sandbox :us: ✅ (new)
e2e_needs_sandbox:ap none sandbox :australia: ✅ (new)
e2e_needs_sandbox:eu:10 none sandbox :eu: ✅ (new)
e2e_needs_sandbox:ca:1.5 none sandbox :maple_leaf: ✅ (new)
e2e_needs_sandbox:gov:dev none sandbox :classical_building: ✅ (new)
e2e_needs_sandbox:uae:10:taPwa none sandbox :united_arab_emirates: ✅ (new)
e2e_needs_sandbox:wu:10:taPwa,navBar none sandbox :us: ✅ (new)
e2e_needs_sandbox:ap:dev:taPwa none sandbox :australia: ✅ (new)
e2e_needs_sandbox:3.13 none none ✅
e2e_needs_sandbox:3.13:eu none none ✅
e2e_needs_sandbox:3.13:10:taPwa none none ✅
e2e__needs_sandbox none none ✅
e2e_needs_sandbo none none ✅
E2E_needs_sandbox none none ✅
xe2e_needs_sandbox none none ✅
please e2e_needs_sandbox none none ✅
e2e_needs_sandbox extra none none ✅
e2e_needs_sandbox:: none none ✅
e2e_needs_sandbox:! none none ✅
e2e_stop_sandbox none none ✅
e2eneeds_sandbox none none ✅

Summary

Category Count Behavior
Old positives (label unchanged) 30 Every needs_sandbox form that previously got labelled still gets the same label
Alt-python needs_sandbox:3.13 (no-op since curr==alt) 12 Matches outer regex but adds no label — same as before
_processor intentional drop 7 Old added sandbox label, new doesn't — expected per PR
Old negatives (no match) 20 Every invalid input still rejected
New e2e_needs_sandbox positives 21 Adds identical labels to needs_sandbox variants
New e2e_needs_sandbox:3.13 (no-op) 3 Matches but no label, same as needs_sandbox:3.13
New e2e_needs_sandbox negatives 10 Typos, uppercase, prefixes all correctly rejected
Total 106 All pass

@tdesai-eightfold
tdesai-eightfold merged commit 5b0df68 into master Apr 22, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants